You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/05/24 12:58:42 UTC
[GitHub] [hive] pvary opened a new pull request, #3320: HIVE-26261: Fix some issues with Spark engine removal
pvary opened a new pull request, #3320:
URL: https://github.com/apache/hive/pull/3320
### What changes were proposed in this pull request?
Fixes for the Spark removal patch
### Why are the changes needed?
Adding back erroneously removed code.
Removing an unused method
### Does this PR introduce _any_ user-facing change?
Just fixes
### How was this patch tested?
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #3320: HIVE-26261: Fix some issues with Spark engine removal
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #3320:
URL: https://github.com/apache/hive/pull/3320#issuecomment-1138149053
@kgyrtkirk: Could you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a diff in pull request #3320: HIVE-26261: Fix some issues with Spark engine removal
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on code in PR #3320:
URL: https://github.com/apache/hive/pull/3320#discussion_r882427374
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/command/CommandAuthorizerV2.java:
##########
@@ -158,6 +158,15 @@ private static boolean isDeferredAuthView(Table t){
if (TableType.MATERIALIZED_VIEW.name().equals(tableType) || TableType.VIRTUAL_VIEW.name().equals(tableType)) {
isView = true;
}
+ if (isView) {
+ Map<String, String> params = t.getParameters();
+ if (params != null && params.containsKey(authorizedKeyword)) {
Review Comment:
nice; so HIVE-25695 effectively mangled the [original condition to be spark dependent](https://github.com/apache/hive/commit/e61460b36178de3d8f2ddb28ad3f03902a34c3a8#diff-b1bce663288d98098d8aaa474ad0694d43484b0cd1977a788dc9f6c6f7fae4d0R163)...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3320: HIVE-26261: Fix some issues with Spark engine removal
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3320:
URL: https://github.com/apache/hive/pull/3320#discussion_r882453126
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/command/CommandAuthorizerV2.java:
##########
@@ -158,6 +158,15 @@ private static boolean isDeferredAuthView(Table t){
if (TableType.MATERIALIZED_VIEW.name().equals(tableType) || TableType.VIRTUAL_VIEW.name().equals(tableType)) {
isView = true;
}
+ if (isView) {
+ Map<String, String> params = t.getParameters();
+ if (params != null && params.containsKey(authorizedKeyword)) {
Review Comment:
In theory this could be used by any other system.
In reality, yes :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary merged pull request #3320: HIVE-26261: Fix some issues with Spark engine removal
Posted by GitBox <gi...@apache.org>.
pvary merged PR #3320:
URL: https://github.com/apache/hive/pull/3320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org