You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/25 22:26:13 UTC

[GitHub] [spark] jackierwzhang opened a new pull request, #36345: [SPARK-39013] Parser change to enforce `()` when creating a table with empty schema

jackierwzhang opened a new pull request, #36345:
URL: https://github.com/apache/spark/pull/36345

   ### What changes were proposed in this pull request?
   As a syntax guard for downstream datasource that could handle empty schema, we enforce user to use `()` during table creation queries.
   
   E.g. `CREATE TABLE table () USING parquet`.
   
   Note that the `[CREATE OR] REPLACE` is excluded from this change due to additional complexity.
   
   ### Why are the changes needed?
   To explicitly make sure user are aware that they are creating a table with no columns.
   
   ### Does this PR introduce _any_ user-facing change?
   Existing code that calls `CREATE TABLE table USING ...` will fail. 
   
   ### How was this patch tested?
   New unit test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] jackierwzhang closed pull request #36345: [SPARK-39013][SQL] Parser change to enforce `()` when creating a table with empty schema

Posted by GitBox <gi...@apache.org>.
jackierwzhang closed pull request #36345: [SPARK-39013][SQL] Parser change to enforce `()` when creating a table with empty schema
URL: https://github.com/apache/spark/pull/36345


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #36345: [SPARK-39013][SQL] Parser change to enforce `()` when creating a table with empty schema

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #36345:
URL: https://github.com/apache/spark/pull/36345#issuecomment-1109668712

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org