You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/01/22 16:03:36 UTC

[GitHub] [libcloud] Kami opened a new pull request #1546: Fix authentication related regression in EC2 driver introduced in v3.3.0

Kami opened a new pull request #1546:
URL: https://github.com/apache/libcloud/pull/1546


   This pull request fixes EC2 driver related authentication regression / bug which was inadvertently introduced in v3.3.0, originally reported in #1545 .
   
   ## Background, Context
   
   #1519 introduced a bug which would cause EC2 driver to always use signature version 2 for authentication.
   
   This won't work with some newer regions which require signature version 4.
   
   This pull request fixes that and also adds a change which allows user to explicitly specify / override which signature version to use for authentication by passing ``signature_version`` argument to the driver constructor.
   
   ## TODO
   
   - [ ] Changelog entry
   - [ ] Add a release note entry on potential workaround


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] codecov-io commented on pull request #1546: Fix authentication related regression in EC2 driver introduced in v3.3.0

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1546:
URL: https://github.com/apache/libcloud/pull/1546#issuecomment-765609512


   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1546?src=pr&el=h1) Report
   > Merging [#1546](https://codecov.io/gh/apache/libcloud/pull/1546?src=pr&el=desc) (ba81fa7) into [trunk](https://codecov.io/gh/apache/libcloud/commit/4370a7021c11c1c61afe6470d2baafc093bfa0dd?el=desc) (4370a70) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1546/graphs/tree.svg?width=650&height=150&src=pr&token=PYoduksh69)](https://codecov.io/gh/apache/libcloud/pull/1546?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##            trunk    #1546   +/-   ##
   =======================================
     Coverage   83.07%   83.08%           
   =======================================
     Files         394      394           
     Lines       84738    84757   +19     
     Branches     9002     9003    +1     
   =======================================
   + Hits        70399    70418   +19     
     Misses      11274    11274           
     Partials     3065     3065           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1546?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [libcloud/compute/constants/ec2\_instance\_types.py](https://codecov.io/gh/apache/libcloud/pull/1546/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX2luc3RhbmNlX3R5cGVzLnB5) | `100.00% <ø> (ø)` | |
   | [...d/compute/constants/ec2\_region\_details\_complete.py](https://codecov.io/gh/apache/libcloud/pull/1546/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX3JlZ2lvbl9kZXRhaWxzX2NvbXBsZXRlLnB5) | `100.00% <ø> (ø)` | |
   | [...ud/compute/constants/ec2\_region\_details\_partial.py](https://codecov.io/gh/apache/libcloud/pull/1546/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX3JlZ2lvbl9kZXRhaWxzX3BhcnRpYWwucHk=) | `100.00% <ø> (ø)` | |
   | [libcloud/compute/drivers/ec2.py](https://codecov.io/gh/apache/libcloud/pull/1546/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL2VjMi5weQ==) | `75.45% <100.00%> (+0.03%)` | :arrow_up: |
   | [libcloud/test/compute/test\_ec2.py](https://codecov.io/gh/apache/libcloud/pull/1546/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3RfZWMyLnB5) | `97.87% <100.00%> (+0.02%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1546?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1546?src=pr&el=footer). Last update [4370a70...ba81fa7](https://codecov.io/gh/apache/libcloud/pull/1546?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] codecov-io edited a comment on pull request #1546: Fix authentication related regression in EC2 driver introduced in v3.3.0

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1546:
URL: https://github.com/apache/libcloud/pull/1546#issuecomment-765609512


   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1546?src=pr&el=h1) Report
   > Merging [#1546](https://codecov.io/gh/apache/libcloud/pull/1546?src=pr&el=desc) (af89afc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/4370a7021c11c1c61afe6470d2baafc093bfa0dd?el=desc) (4370a70) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1546/graphs/tree.svg?width=650&height=150&src=pr&token=PYoduksh69)](https://codecov.io/gh/apache/libcloud/pull/1546?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##            trunk    #1546   +/-   ##
   =======================================
     Coverage   83.07%   83.08%           
   =======================================
     Files         394      394           
     Lines       84738    84761   +23     
     Branches     9002     9003    +1     
   =======================================
   + Hits        70399    70422   +23     
     Misses      11274    11274           
     Partials     3065     3065           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1546?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [libcloud/compute/constants/ec2\_instance\_types.py](https://codecov.io/gh/apache/libcloud/pull/1546/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX2luc3RhbmNlX3R5cGVzLnB5) | `100.00% <ø> (ø)` | |
   | [...d/compute/constants/ec2\_region\_details\_complete.py](https://codecov.io/gh/apache/libcloud/pull/1546/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX3JlZ2lvbl9kZXRhaWxzX2NvbXBsZXRlLnB5) | `100.00% <ø> (ø)` | |
   | [...ud/compute/constants/ec2\_region\_details\_partial.py](https://codecov.io/gh/apache/libcloud/pull/1546/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX3JlZ2lvbl9kZXRhaWxzX3BhcnRpYWwucHk=) | `100.00% <ø> (ø)` | |
   | [libcloud/compute/drivers/ec2.py](https://codecov.io/gh/apache/libcloud/pull/1546/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL2VjMi5weQ==) | `75.45% <100.00%> (+0.03%)` | :arrow_up: |
   | [libcloud/test/compute/test\_ec2.py](https://codecov.io/gh/apache/libcloud/pull/1546/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3RfZWMyLnB5) | `97.88% <100.00%> (+0.03%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1546?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1546?src=pr&el=footer). Last update [4370a70...af89afc](https://codecov.io/gh/apache/libcloud/pull/1546?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami merged pull request #1546: Fix authentication related regression in EC2 driver introduced in v3.3.0

Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1546:
URL: https://github.com/apache/libcloud/pull/1546


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami commented on pull request #1546: Fix authentication related regression in EC2 driver introduced in v3.3.0

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1546:
URL: https://github.com/apache/libcloud/pull/1546#issuecomment-765640598


   I'll go ahead and merge this since I hope to start voting thread for a bug fix release today.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org