[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #4841: [Fix-4839][Server] Process cannot stop when killed with retry

[GitBox <gi...@apache.org>]

CalvinKirs commented on a change in pull request #4841:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4841#discussion_r581997059



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ExecutionStatus.java
##########
@@ -90,7 +90,7 @@ public boolean typeIsSuccess() {
      * @return status
      */
     public boolean typeIsFailure() {
-        return this == FAILURE || this == NEED_FAULT_TOLERANCE || this == KILL;
+        return this == FAILURE || this == NEED_FAULT_TOLERANCE;
     }

Review comment:
       What worries me is that modifying this will cause abnormal business logic judgments elsewhere




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org