You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/22 09:43:08 UTC

[GitHub] [apisix] LY-GO commented on issue #2448: chore: `limit-req` plugin code optimization

LY-GO commented on issue #2448:
URL: https://github.com/apache/apisix/issues/2448#issuecomment-714370571


   > ### Issue description
   > This part of the code ( https://github.com/apache/apisix/blob/master/apisix/plugins/limit-req.lua#L70-L80)
   > can be replaced with "`local key = (ctx.var[conf.key] or "") .. ctx.conf_type .. ctx.conf_version`" .
   If i want to use service_name to limit,i just modify key;just like so
   ![service-name](https://user-images.githubusercontent.com/67543312/96854379-ff3c0580-148d-11eb-9ebf-4d13a4765f94.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org