[jira] [Commented] (GOSSIP-85) UDP Server moved to sub module

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GOSSIP-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990833#comment-15990833 ] 

ASF GitHub Bot commented on GOSSIP-85:
--------------------------------------

Github user gdusbabek commented on the issue:

    https://github.com/apache/incubator-gossip/pull/50
  
    I think it would have made more sense to push the PassiveGossip instance inside the UDPTransportManager. Two reasons:
    
    1. Keeping it as an abstract class presupposes that every TransportManager implementation is going require one. Thinking ahead a little bit to what would be required for HTTP (for example: a simple Netty server)--we wouldn't need a passive gossip thread because all that functionality would be wrapped up in Netting wiring.
    2. As an interface AbstractPassiveGossiper duplicates some methods already specified in TransportManager, forcing implementers to do things twice, or worse have interface A call interface B.


> UDP Server moved to sub module
> ------------------------------
>
>                 Key: GOSSIP-85
>                 URL: https://issues.apache.org/jira/browse/GOSSIP-85
>             Project: Gossip
>          Issue Type: Improvement
>            Reporter: Edward Capriolo
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)