You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2024/02/01 22:48:52 UTC
[PR] Update Gradle Tooling API wrapper to 8.5 [netbeans]
mbien opened a new pull request, #7022:
URL: https://github.com/apache/netbeans/pull/7022
8.5 now supports running on JDK 21
targets delivery
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Gradle Tooling API wrapper to 8.5 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7022:
URL: https://github.com/apache/netbeans/pull/7022#issuecomment-1925397598
closing in favor of #6926 since 8.6 was just released. To make neil's decision easier to figure out what to merge ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Gradle Tooling API wrapper to 8.5 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7022:
URL: https://github.com/apache/netbeans/pull/7022#issuecomment-1924096290
> I won't be able to test until next week, but on principle I'm -0.5 on this one.
>
> Why? What issues are fixed with this? The tooling API is meant to be forward compatible,
I actually don't have any race horses in the race here or whatever the correct sentence is :)
NB 21rc2 on JDK 21:
With this PR applied I didn't get the "resolve problems dialog". I simply assumed that we forgot to update the lib wrapper to 8.5, so I quickly opened this PR. The gradle tests can also currently not run on JDK 21 which I was re minded of while doing #7019.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Gradle Tooling API wrapper to 8.5 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7022:
URL: https://github.com/apache/netbeans/pull/7022#issuecomment-1922449474
> Does not `manifest.mf` module version need bumping ?
@sdedic AFAIK no, since this is done once per release anyway via https://github.com/apache/netbeans/pull/6576, https://github.com/apache/netbeans/pull/6959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Gradle Tooling API wrapper to 8.5 [netbeans]
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on PR #7022:
URL: https://github.com/apache/netbeans/pull/7022#issuecomment-1923512378
Well, there is one painful shortcoming in NB Gradle support. The Boot Classpath of a project is actually taken from the Runtime Classpath: https://github.com/apache/netbeans/blob/681aa7656757ed9ddc7c2f19af8360f85dcfdf66/java/gradle.java/src/org/netbeans/modules/gradle/java/classpath/BootClassPathImpl.java#L72
That would make the use of the new Java 21 API-s uncomfortable (would not be appear, marked red, but would compile after all)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Gradle Tooling API wrapper to 8.5 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7022:
URL: https://github.com/apache/netbeans/pull/7022#issuecomment-1922587726
seems to be working. It didn't complain about JDK 21 when I tested it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Gradle Tooling API wrapper to 8.5 [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #7022:
URL: https://github.com/apache/netbeans/pull/7022#issuecomment-1922439779
Does not need `manifest.mf` module version bumping ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Gradle Tooling API wrapper to 8.5 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien closed pull request #7022: Update Gradle Tooling API wrapper to 8.5
URL: https://github.com/apache/netbeans/pull/7022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Gradle Tooling API wrapper to 8.5 [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #7022:
URL: https://github.com/apache/netbeans/pull/7022#issuecomment-1923280638
I won't be able to test until next week, but on principle I'm -0.5 on this one.
Why? What issues are fixed with this? The tooling API is meant to be forward compatible, and afaik does not suffer from the same max JDK concerns. So what problems with it or our use of it require an update just as we're about to finalise the release? And are there other ways to address those now or in future so that doesn't happen again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists