You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by kavinkumarks <gi...@git.apache.org> on 2016/08/19 13:00:34 UTC
[GitHub] zeppelin pull request #1348: [ZEPPELIN-1313] NullPointerException when using...
GitHub user kavinkumarks opened a pull request:
https://github.com/apache/zeppelin/pull/1348
[ZEPPELIN-1313] NullPointerException when using Clone notebook REST API
### What is this PR for?
This fixes when the input json is empty for the clone notebook REST API and for this case the default name will be populated.
### What type of PR is it?
Bug Fix
### Todos
NA
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1313
### How should this be tested?
When the input json is empty for the clone notebook REST API, the response should be 201 with the default name populated.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kavinkumarks/zeppelin zeppelin-1313-fix-NPE-clone-notebook
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1348.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1348
----
commit 19aa878e0183530ef113790e6e1275efa8d59fde
Author: Kavin Kumar <ju...@gmail.com>
Date: 2016-08-19T12:51:43Z
Fixed NPE when the input json is empty for clone notebook REST API and
set the default name for the case.Added test cases too.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1348: [ZEPPELIN-1313] NullPointerException when using...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks closed the pull request at:
https://github.com/apache/zeppelin/pull/1348
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1348
@AhyoungRyu Could you please merge this PR? [This](https://cwiki.apache.org/confluence/display/ZEPPELIN/Committer+Guide) will help you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1348
@jongyoul @felixcheung Sure. Let me try :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1348: [ZEPPELIN-1313] NullPointerException when using...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1348
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1348
Right, when I say "you" I mean Ahyoung :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1348
@felixcheung / @jongyoul any updates on this?
Thanks,
Kavin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1348
Thanks everyone!
- Kavin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1348: [ZEPPELIN-1313] NullPointerException when using...
Posted by kavinkumarks <gi...@git.apache.org>.
GitHub user kavinkumarks reopened a pull request:
https://github.com/apache/zeppelin/pull/1348
[ZEPPELIN-1313] NullPointerException when using Clone notebook REST API
### What is this PR for?
This fixes when the input json is empty for the clone notebook REST API and for this case the default name will be populated.
### What type of PR is it?
Bug Fix
### Todos
NA
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1313
### How should this be tested?
When the input json is empty for the clone notebook REST API, the response should be 201 with the default name populated.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kavinkumarks/zeppelin zeppelin-1313-fix-NPE-clone-notebook
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1348.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1348
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1348
Reopening to trigger the CI build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1348: [ZEPPELIN-1313] NullPointerException when using...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks closed the pull request at:
https://github.com/apache/zeppelin/pull/1348
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1348
@felixcheung Yeah, @kavinkumarks already did it, thus I also am OK to include it. CI failure is not related to this PR. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1348
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1348
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1348
I agree, that should be a separate PR/JIRA.
I'm ok with including it now since changes are already made? Is CI passing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1348
I could also merge this tomorrow if you are having problems.
Sorry about the delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1348
@kavinkumarks Thanks for the removing the method, but personally, I think we should handle it with another PR. @felixcheung What do you think of it? It looks irrelevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1348
@felixcheung I don't have any problem. I'd like to give @AhyoungRyu a chance to merge PR for the first time. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1348
@felixcheung / @jongyoul could you please take care of merging this?
Thanks,
Kavin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1348: [ZEPPELIN-1313] NullPointerException when using...
Posted by kavinkumarks <gi...@git.apache.org>.
GitHub user kavinkumarks reopened a pull request:
https://github.com/apache/zeppelin/pull/1348
[ZEPPELIN-1313] NullPointerException when using Clone notebook REST API
### What is this PR for?
This fixes when the input json is empty for the clone notebook REST API and for this case the default name will be populated.
### What type of PR is it?
Bug Fix
### Todos
NA
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1313
### How should this be tested?
When the input json is empty for the clone notebook REST API, the response should be 201 with the default name populated.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kavinkumarks/zeppelin zeppelin-1313-fix-NPE-clone-notebook
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1348.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1348
----
commit 19aa878e0183530ef113790e6e1275efa8d59fde
Author: Kavin Kumar <ju...@gmail.com>
Date: 2016-08-19T12:51:43Z
Fixed NPE when the input json is empty for clone notebook REST API and
set the default name for the case.Added test cases too.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1348
Reopening to trigger the CI build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1348
The CI build is green refer to https://travis-ci.org/apache/zeppelin/builds/154093445
Could someone please review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---