You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2009/04/27 19:59:27 UTC

DO NOT REPLY [Bug 47108] New: Conditional edit

https://issues.apache.org/bugzilla/show_bug.cgi?id=47108

           Summary: Conditional edit
           Product: Apache httpd-2
           Version: 2.2.9
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: mod_headers
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: anny.mak@springsource.com


When there are multiple header that has the same name, set-cookie in
particular, Header cannot modify/edit a particular set-cookie in the set based
on a particular pattern in the cookie.  We can only replace a matching pattern
in the header with a new pattern.  It does not have the capability to
add/append extra value to the header with the matching pattern in the header.

For example, the following is in the headers:

Set-Cookie: secure; httponly
Set-Cookie: PHHCHALLENGE=; expires=Tue, 12 Aug 2008 13:09:54 GMT; path=/;
domain=.company.com 
Set-Cookie: PHHSESSION=xyz; path=/; domain=.company.com 

I cannot append "httponly" to the Set-Cookie header that has PHHSESSSION be
xyz.

We are requesting an enhancement on conditional "Header edit".

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 47108] Conditional edit

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47108





--- Comment #1 from Will Rowe <wr...@apache.org>  2009-04-27 11:32:13 PST ---
Both the specific bug [set/append not working correctly for cookie headers] and 
Headers edit are entirely addressed by 2.3-trunk.

I'd be partial to just backporting the current mod_headers module to 2.2 and
calling it a day; will propose in STATUS.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 47108] Conditional edit

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47108


Will Rowe <wr...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Will Rowe <wr...@apache.org>  2009-04-27 14:09:21 PST ---
Actually; this was already done;

https://svn.apache.org/viewvc?view=rev&revision=684100

and was part of httpd 2.2.10

There is only one open patch which is an aspect of content-type handling;

@@ -680,6 +680,9 @@
             }
             break;
         case hdr_set:
+            if (!strcasecmp(hdr->header, "Content-Type")) {
+                 ap_set_content_type(r, process_tags(hdr, r));
+            }
             apr_table_setn(headers, hdr->header, process_tags(hdr, r));
             break;
         case hdr_unset:

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org