You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/08/28 23:26:43 UTC
[GitHub] [helix] jiajunwang removed a comment on issue #381: Implement the
POC work greedy constraint based algorithm
jiajunwang removed a comment on issue #381: Implement the POC work greedy constraint based algorithm
URL: https://github.com/apache/helix/pull/381#issuecomment-525959563
> @jiajunwang @i3wangyi What was the reason for adding assignment info to ClusterModel in the first place? I feel that we should have just one source of truth for the assignment result. What about ClusterContext? Could we discuss and clearly define the roles of each? (ClusterModel, ClusterContext, and OptimalAssignment).
Our original design was that ClusterModel will be in input and output. But what @i3wangyi proposed is that, ClusterModel will be the input and readonly. We update to OptimalAssignment only. That is to be done. Not in this PR yet.
@i3wangyi Could you please add enough TODO to clarify it?
ClusterContext is contained in the ClusterModel. And should not be viewable by the other components including the rebalancer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org