[GitHub] [airflow] uranusjr commented on a change in pull request #20120: Fix various MyPy issues in airflow/www folder (part 1)

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #20120:
URL: https://github.com/apache/airflow/pull/20120#discussion_r764571216



##########
File path: airflow/www/extensions/init_appbuilder.py
##########
@@ -560,7 +561,7 @@ def security_converge(self, dry=False) -> Dict:
         :param dry: If True will not change DB
         :return: Dict with all computed necessary operations
         """
-        return self.sm.security_converge(self.baseviews, self.menu, dry)
+        return self.sm.security_converge(self.baseviews, self.menu, dry)  # type: ignore

Review comment:
       What is the Mypy error this is ignoring?

##########
File path: airflow/www/views.py
##########
@@ -543,7 +543,7 @@ class AirflowBaseView(BaseView):
     }
 
     if not conf.getboolean('core', 'unit_test_mode'):
-        extra_args['sqlite_warning'] = settings.Session.bind.dialect.name == 'sqlite'
+        extra_args['sqlite_warning'] = settings.Session.bind.dialect.name == 'sqlite'  # type: ignore

Review comment:
       This will not be needed if we manage to resolve https://github.com/apache/airflow/pull/20096#pullrequestreview-825466253. (Not saying you should remove it right now, just a reminder to track changes there and adapt this PR is that’s merged first.)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org