You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2014/09/03 15:37:51 UTC

[jira] [Commented] (BOOKKEEPER-778) Flake in TestTryReadLastConfirmed

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119855#comment-14119855 ] 

Flavio Junqueira commented on BOOKKEEPER-778:
---------------------------------------------

The test modified in the patch seems a bit odd to me overall. For example, I don't understand why we are killing bookies in every iteration of the outer for loop. Perhaps the original intention was to open lh in each iteration? Also, looping numEntries times seems arbitrary because all this seems to be checking is that the callback result make sense for some arbitrary number of calls.

> Flake in TestTryReadLastConfirmed
> ---------------------------------
>
>                 Key: BOOKKEEPER-778
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-778
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-778-Flake-in-TestTryReadLastConfirmed.patch, TEST-org.apache.bookkeeper.client.TestTryReadLastConfirmed.xml.fail1, TEST-org.apache.bookkeeper.client.TestTryReadLastConfirmed.xml.fail2, TEST-org.apache.bookkeeper.client.TestTryReadLastConfirmed.xml.fail3
>
>
> Logs attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)