You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2014/11/24 23:42:18 UTC

Re: Review Request 28420: Fixed typos in comments for example module implementation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28420/
-----------------------------------------------------------

(Updated Nov. 24, 2014, 5:42 p.m.)


Review request for mesos and Timothy Chen.


Summary (updated)
-----------------

Fixed typos in comments for example module implementation.


Repository: mesos-git


Description
-------

Replaced "example" with "org_apache_mesos_TestModule".


Diffs
-----

  docs/modules.md 474e2dfed4a45111b70ce5b3f88e9888e501fad2 
  src/examples/example_module_impl.cpp 1e282216dc49c88e0b16e03b0015f66753836939 

Diff: https://reviews.apache.org/r/28420/diff/


Testing
-------


Thanks,

Kapil Arya


Re: Review Request 28420: Fixed typos in comments for example module implementation.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28420/#review62901
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Nov. 24, 2014, 10:42 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28420/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 10:42 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Replaced "example" with "org_apache_mesos_TestModule".
> 
> 
> Diffs
> -----
> 
>   docs/modules.md 474e2dfed4a45111b70ce5b3f88e9888e501fad2 
>   src/examples/example_module_impl.cpp 1e282216dc49c88e0b16e03b0015f66753836939 
> 
> Diff: https://reviews.apache.org/r/28420/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 28420: Fixed typos in comments for example module implementation.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28420/#review62904
-----------------------------------------------------------


Patch looks great!

Reviews applied: [28420]

All tests passed.

- Mesos ReviewBot


On Nov. 24, 2014, 10:42 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28420/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 10:42 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Replaced "example" with "org_apache_mesos_TestModule".
> 
> 
> Diffs
> -----
> 
>   docs/modules.md 474e2dfed4a45111b70ce5b3f88e9888e501fad2 
>   src/examples/example_module_impl.cpp 1e282216dc49c88e0b16e03b0015f66753836939 
> 
> Diff: https://reviews.apache.org/r/28420/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>