You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ben Lau (JIRA)" <ji...@apache.org> on 2018/02/13 22:38:00 UTC
[jira] [Commented] (HBASE-18282) ReplicationLogCleaner can delete
WALs not yet replicated in case of a KeeperException
[ https://issues.apache.org/jira/browse/HBASE-18282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363168#comment-16363168 ]
Ben Lau commented on HBASE-18282:
---------------------------------
Hi guys, this ticket has been open for a while. Do you mind if we submit an internal patch + test we have for this?
> ReplicationLogCleaner can delete WALs not yet replicated in case of a KeeperException
> -------------------------------------------------------------------------------------
>
> Key: HBASE-18282
> URL: https://issues.apache.org/jira/browse/HBASE-18282
> Project: HBase
> Issue Type: Bug
> Components: Replication
> Affects Versions: 1.3.1, 1.2.6, 1.1.11, 2.0.0-alpha-1
> Reporter: Ashu Pachauri
> Assignee: Ashu Pachauri
> Priority: Critical
>
> ReplicationStateZKBase#getListOfReplicators does not rethrow a KeeperException and returns null in such a case. ReplicationLogCleaner just assumes that there are no replicators and deletes everything.
> ReplicationStateZKBase:
> {code:java}
> public List<String> getListOfReplicators() {
> List<String> result = null;
> try {
> result = ZKUtil.listChildrenNoWatch(this.zookeeper, this.queuesZNode);
> } catch (KeeperException e) {
> this.abortable.abort("Failed to get list of replicators", e);
> }
> return result;
> }
> {code}
> ReplicationLogCleaner:
> {code:java}
> private Set<String> loadWALsFromQueues() throws KeeperException {
> for (int retry = 0; ; retry++) {
> int v0 = replicationQueues.getQueuesZNodeCversion();
> List<String> rss = replicationQueues.getListOfReplicators();
> if (rss == null) {
> LOG.debug("Didn't find any region server that replicates, won't prevent any deletions.");
> return ImmutableSet.of();
> }
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)