You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/12/02 04:02:29 UTC
[PR] [SPARK-46205][CORE][TESTS][FOLLOWUP] Simplify PersistenceEngineBenchmark [spark]
dongjoon-hyun opened a new pull request, #44118:
URL: https://github.com/apache/spark/pull/44118
### What changes were proposed in this pull request?
This is a follow-up of #44113 to address a comment about simplifying the benchmark.
### Why are the changes needed?
To simplify.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manually.
```
$ build/sbt "core/Test/runMain org.apache.spark.deploy.master.PersistenceEngineBenchmark"
...
[info] OpenJDK 64-Bit Server VM 17.0.9+9-LTS on Mac OS X 14.2
[info] Apple M1 Max
[info] 1000 Workers: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
[info] -------------------------------------------------------------------------------------------------------------------------------
[info] ZooKeeperPersistenceEngine with JavaSerializer 12602 12847 253 0.0 12601717.5 1.0X
[info] ZooKeeperPersistenceEngine with KryoSerializer 12116 12130 13 0.0 12116373.8 1.0X
[info] FileSystemPersistenceEngine with JavaSerializer 429 435 6 0.0 429374.9 29.3X
[info] FileSystemPersistenceEngine with KryoSerializer 179 180 2 0.0 178795.7 70.5X
[info] BlackHolePersistenceEngine 0 0 0 46.6 21.5 587273.6X
[success] Total time: 126 s (02:06), completed Dec 1, 2023, 7:59:25 PM
```
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE][TESTS][FOLLOWUP] Simplify PersistenceEngineBenchmark [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44118:
URL: https://github.com/apache/spark/pull/44118#issuecomment-1837232922
Could you review this PR, @LuciferYang ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE][TESTS][FOLLOWUP] Simplify PersistenceEngineBenchmark [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44118:
URL: https://github.com/apache/spark/pull/44118#issuecomment-1837234980
Thank you, @LuciferYang . Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE][TESTS][FOLLOWUP] Simplify PersistenceEngineBenchmark [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44118: [SPARK-46205][CORE][TESTS][FOLLOWUP] Simplify PersistenceEngineBenchmark
URL: https://github.com/apache/spark/pull/44118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE][TESTS][FOLLOWUP] Simplify PersistenceEngineBenchmark [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44118:
URL: https://github.com/apache/spark/pull/44118#issuecomment-1837030112
Hi, @beliefer . This is the follow-up PR for your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org