You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/10 09:23:34 UTC

[GitHub] [rocketmq] panzhi33 commented on issue #3617: Why does case SLAVE_NOT_AVALIABLE roll back when sending transaction messages

panzhi33 commented on issue #3617:
URL: https://github.com/apache/rocketmq/issues/3617#issuecomment-990768344


   > public TransactionSendResult sendMessageInTransaction case SLAVE_NOT_AVAILABLE: localTransactionState = LocalTransactionState.ROLLBACK_MESSAGE; break; According to the above code, the transaction message will be rolled back when SLAVE_NOT_AVAILABLE
   
   yes，I didn't look carefully. I feel that the design here is not very reasonable. In org.apache.rocketmq.broker.processor.EndTransactionProcessor#sendFinalMessage, SLAVE_NOT_AVAILABLE is successful. And other message types are also successful by default. I think it needs to be unified here
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org