[GitHub] [netbeans] iamstolis commented on a change in pull request #2372: Update dependencies to GraalVM 20.2.0

[GitBox <gi...@apache.org>]

iamstolis commented on a change in pull request #2372:
URL: https://github.com/apache/netbeans/pull/2372#discussion_r490750350



##########
File path: platform/api.scripting/test/unit/src/org/netbeans/api/scripting/JavaScriptEnginesTest.java
##########
@@ -256,7 +256,7 @@ public void allowLoadAClassInJS() throws Exception {
         // BEGIN: org.netbeans.api.scripting.JavaScriptEnginesTest#allowLoadAClassInJS
         Object fn = engine.eval("(function(obj) {\n"
                 + "  var Long = Java.type('java.lang.Long');\n"
-                + "  return new Long(33);\n"
+                + "  return new Long(\"33\");\n"

Review comment:
       Yes, this is a known consequence of the new conversion and also a known workaround that removes the new conversion see https://github.com/graalvm/graaljs/issues/286
   
   Note that the conversion itself is not incorrect (in the sense that Nashorn has it as well and so some Nashorn users need it). Unfortunately, the inclusion of the conversion discloses that our method resolution (in `truffle`) is different than Nashorn one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists