You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/31 01:19:45 UTC
[kudu-CR] [build-support] fix on enable devtoolset inner.sh
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14595
Change subject: [build-support] fix on enable_devtoolset_inner.sh
......................................................................
[build-support] fix on enable_devtoolset_inner.sh
When ccache is not present on the build machine, the prior version
of this script output an error:
enable_devtoolset_inner.sh: line 28: [: too many arguments
This patch fixes this minor issue.
Change-Id: I49b1db9933371304674b148cc4d71c3703be1772
---
M build-support/enable_devtoolset_inner.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/14595/1
--
To view, visit http://gerrit.cloudera.org:8080/14595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49b1db9933371304674b148cc4d71c3703be1772
Gerrit-Change-Number: 14595
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [build-support] fix on enable devtoolset inner.sh
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14595 )
Change subject: [build-support] fix on enable_devtoolset_inner.sh
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49b1db9933371304674b148cc4d71c3703be1772
Gerrit-Change-Number: 14595
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 31 Oct 2019 17:54:39 +0000
Gerrit-HasComments: No
[kudu-CR] [build-support] fix on enable devtoolset inner.sh
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14595 )
Change subject: [build-support] fix on enable_devtoolset_inner.sh
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49b1db9933371304674b148cc4d71c3703be1772
Gerrit-Change-Number: 14595
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 31 Oct 2019 17:59:37 +0000
Gerrit-HasComments: No
[kudu-CR] [build-support] fix on enable devtoolset inner.sh
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14595 )
Change subject: [build-support] fix on enable_devtoolset_inner.sh
......................................................................
[build-support] fix on enable_devtoolset_inner.sh
When ccache is not present on the build machine, the prior version
of this script output an error:
enable_devtoolset_inner.sh: line 28: [: too many arguments
This patch fixes this minor issue.
Change-Id: I49b1db9933371304674b148cc4d71c3703be1772
Reviewed-on: http://gerrit.cloudera.org:8080/14595
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M build-support/enable_devtoolset_inner.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I49b1db9933371304674b148cc4d71c3703be1772
Gerrit-Change-Number: 14595
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)