You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/10/16 17:28:00 UTC

[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1187: chore(CI): disable some flaky tests

empiredan commented on code in PR #1187:
URL: https://github.com/apache/incubator-pegasus/pull/1187#discussion_r996469403


##########
.github/workflows/lint_and_test_cpp.yaml:
##########
@@ -257,13 +257,17 @@ jobs:
           - dsn_runtime_tests
           - dsn_utils_tests
           - dsn.zookeeper.tests
-          - partition_split_test
+          # TODO(yingchun): Disable it because we find it's too flacky, we will re-enable it after
+          # it has been optimized.
+#          - partition_split_test

Review Comment:
   Actually `partition_split_test` and `dsn.meta.test` often failed for `test_Release` too, should both of them be disabled temporarily ?



##########
.github/workflows/lint_and_test_cpp.yaml:
##########
@@ -257,13 +257,17 @@ jobs:
           - dsn_runtime_tests
           - dsn_utils_tests
           - dsn.zookeeper.tests
-          - partition_split_test
+          # TODO(yingchun): Disable it because we find it's too flacky, we will re-enable it after

Review Comment:
   ```suggestion
             # TODO(yingchun): Disable it because we find it's too flaky, we will re-enable it after
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org