You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/04/25 04:28:20 UTC
[GitHub] [superset] justinpark opened a new pull request, #23805: fix(sqllab): test failed due to legacy api url
justinpark opened a new pull request, #23805:
URL: https://github.com/apache/superset/pull/23805
### SUMMARY
Following unit test failed due to #22916
It's because the test uses the legacy api endpoint but the api is migrated to new [endpoint](https://github.com/apache/superset/pull/22931/files#diff-1fe9f23910bda67f66ff7b5e9127cdaba0d304153a5246dbcb2d76d70d2e5a4fR1516)
It looks like the PR made and passed CI before the api migration completed.
This commit fixes the test code to pass the CI
```
FAIL src/SqlLab/components/ExploreCtasResultsButton/ExploreCtasResultsButton.test.tsx (5.404 s)
● Console
console.warn
You are using a whole package of antd, please use https://www.npmjs.com/package/babel-plugin-import to reduce app bundle size.
at Module../components/index.tsx (node_modules/antd/dist/webpack:/antd/components/index.tsx:10:13)
at require (node_modules/antd/dist/webpack:/antd/webpack/bootstrap:19:1)
at Object../index-with-locales.js (node_modules/antd/dist/webpack:/antd/index-with-locales.js:1:14)
at __webpack_require__ (node_modules/antd/dist/webpack:/antd/webpack/bootstrap:19:1)
at node_modules/antd/dist/webpack:/antd/webpack/bootstrap:83:1
at node_modules/antd/dist/antd-with-locales.js:105:10
at webpackUniversalModuleDefinition (node_modules/antd/dist/webpack:/antd/webpack/universalModuleDefinition:3:1)
at Object.<anonymous> (node_modules/antd/dist/webpack:/antd/webpack/universalModuleDefinition:10:2)
```
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23805: fix(sqllab): test failed due to legacy api url
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23805:
URL: https://github.com/apache/superset/pull/23805#issuecomment-1521169473
## [Codecov](https://codecov.io/gh/apache/superset/pull/23805?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23805](https://codecov.io/gh/apache/superset/pull/23805?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90bda90) into [master](https://codecov.io/gh/apache/superset/commit/742c2cd8fb13090a858f4f35088b4113c009a6b5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (742c2cd) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 90bda90 differs from pull request most recent head 4f975ef. Consider uploading reports for the commit 4f975ef to get more accurate results
```diff
@@ Coverage Diff @@
## master #23805 +/- ##
==========================================
+ Coverage 67.98% 68.02% +0.03%
==========================================
Files 1936 1936
Lines 74928 74929 +1
Branches 8140 8141 +1
==========================================
+ Hits 50942 50970 +28
+ Misses 21894 21871 -23
+ Partials 2092 2088 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.28% <ø> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 5 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23805/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark merged pull request #23805: fix(sqllab): test failed due to legacy api url
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #23805:
URL: https://github.com/apache/superset/pull/23805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org