You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Divesh Dutta (JIRA)" <ji...@apache.org> on 2010/04/14 11:28:54 UTC
[jira] Created: (OFBIZ-3697) setLastInventoryCount Service should
not be called hourly due to performance issues.
setLastInventoryCount Service should not be called hourly due to performance issues.
------------------------------------------------------------------------------------
Key: OFBIZ-3697
URL: https://issues.apache.org/jira/browse/OFBIZ-3697
Project: OFBiz
Issue Type: Improvement
Components: product
Affects Versions: SVN trunk
Reporter: Divesh Dutta
Fix For: SVN trunk
1) In case of large database, when there are so many products into the system, then setLastInventoryCount service consider all the products and update records for them.
2) So it will keep server busy for some time in every one hour. This logic should be improved.
3) Also setLastInventoryCount service does not take facilityId into the account while setting last inventory count in ProductFacility entity.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-3697) setLastInventoryCount Service should
not be called hourly due to performance issues.
Posted by "Divesh Dutta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Divesh Dutta updated OFBIZ-3697:
--------------------------------
Attachment: OFBiz-3697.patch
This patch solves the following problem:
1) Now setLastInventoryCount service will run as EECA (on InventoryItemDetail entity, such that availableToPromiseDiff != 0) and updates lastInventoryCount for products available in facility in ProductFacility entity
2) So setLastInventoryCount service will only run for products whose ATPs are changed, not for all the products in every one hour. So definitely this will improve the performance of the server.
3) Also lastInventoryCount value is updated according to facility.
> setLastInventoryCount Service should not be called hourly due to performance issues.
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-3697
> URL: https://issues.apache.org/jira/browse/OFBIZ-3697
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Fix For: SVN trunk
>
> Attachments: OFBiz-3697.patch
>
>
> 1) In case of large database, when there are so many products into the system, then setLastInventoryCount service consider all the products and update records for them.
> 2) So it will keep server busy for some time in every one hour. This logic should be improved.
> 3) Also setLastInventoryCount service does not take facilityId into the account while setting last inventory count in ProductFacility entity.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3697) setLastInventoryCount Service should
not be called hourly due to performance issues.
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856820#action_12856820 ]
Pranay Pandey commented on OFBIZ-3697:
--------------------------------------
Thanks Divesh for this improvement. I have reviewed the patch and looks good.
> setLastInventoryCount Service should not be called hourly due to performance issues.
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-3697
> URL: https://issues.apache.org/jira/browse/OFBIZ-3697
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Ashish Vijaywargiya
> Fix For: SVN trunk
>
> Attachments: OFBiz-3697.patch
>
>
> 1) In case of large database, when there are so many products into the system, then setLastInventoryCount service consider all the products and update records for them.
> 2) So it will keep server busy for some time in every one hour. This logic should be improved.
> 3) Also setLastInventoryCount service does not take facilityId into the account while setting last inventory count in ProductFacility entity.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (OFBIZ-3697) setLastInventoryCount Service should
not be called hourly due to performance issues.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya reassigned OFBIZ-3697:
------------------------------------------
Assignee: Ashish Vijaywargiya
> setLastInventoryCount Service should not be called hourly due to performance issues.
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-3697
> URL: https://issues.apache.org/jira/browse/OFBIZ-3697
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Ashish Vijaywargiya
> Fix For: SVN trunk
>
> Attachments: OFBiz-3697.patch
>
>
> 1) In case of large database, when there are so many products into the system, then setLastInventoryCount service consider all the products and update records for them.
> 2) So it will keep server busy for some time in every one hour. This logic should be improved.
> 3) Also setLastInventoryCount service does not take facilityId into the account while setting last inventory count in ProductFacility entity.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-3697) setLastInventoryCount Service should
not be called hourly due to performance issues.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya closed OFBIZ-3697.
--------------------------------------
Resolution: Fixed
Thanks Divesh & Pranay for the contribution - Committed at r933906.
--
Ashish Vijaywargiya
> setLastInventoryCount Service should not be called hourly due to performance issues.
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-3697
> URL: https://issues.apache.org/jira/browse/OFBIZ-3697
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Ashish Vijaywargiya
> Fix For: SVN trunk
>
> Attachments: OFBiz-3697.patch
>
>
> 1) In case of large database, when there are so many products into the system, then setLastInventoryCount service consider all the products and update records for them.
> 2) So it will keep server busy for some time in every one hour. This logic should be improved.
> 3) Also setLastInventoryCount service does not take facilityId into the account while setting last inventory count in ProductFacility entity.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3697) setLastInventoryCount Service should
not be called hourly due to performance issues.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861296#action_12861296 ]
Jacques Le Roux commented on OFBIZ-3697:
----------------------------------------
Not sure it's related but I saw this error in my log while testing another stuff
2010-04-27 10:00:01,406 (default-invoker-Thread-7) [ ModelService.java:564:ERROR] [ModelService.validate] : {setLastInventoryCount} : (IN) Required test error: org.ofbiz.serv
on: The following required parameter is missing: [IN] [setLastInventoryCount.inventoryItemId]
2010-04-27 10:00:01,406 (default-invoker-Thread-9) [ UtilProperties.java:932:INFO ] ResourceBundle ServiceErrorUiLabels (en) created in 0.0s with 0 properties
2010-04-27 10:00:01,406 (default-invoker-Thread-9) [ ModelService.java:564:ERROR] [ModelService.validate] : {setLastInventoryCount} : (IN) Required test error: org.ofbiz.serv
on: The following required parameter is missing: [IN] [setLastInventoryCount.inventoryItemId]
2010-04-27 10:00:01,406 (default-invoker-Thread-7) [ ServiceDispatcher.java:381:ERROR]
---- exception report ----------------------------------------------------------
Incoming context (in runSync : setLastInventoryCount) does not match expected requirements
Exception: org.ofbiz.service.ServiceValidationException
Message: The following required parameter is missing: [IN] [setLastInventoryCount.inventoryItemId]
---- stack trace ---------------------------------------------------------------
org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [IN] [setLastInventoryCount.inventoryItemId]
org.ofbiz.service.ModelService.validate(ModelService.java:625)
org.ofbiz.service.ModelService.validate(ModelService.java:561)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:379)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:226)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:165)
org.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:70)
org.ofbiz.service.job.JobInvoker.run(JobInvoker.java:242)
java.lang.Thread.run(Thread.java:619)
--------------------------------------------------------------------------------
Maybe I needed to clean-all, anyway I report here for now...
> setLastInventoryCount Service should not be called hourly due to performance issues.
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-3697
> URL: https://issues.apache.org/jira/browse/OFBIZ-3697
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Ashish Vijaywargiya
> Fix For: SVN trunk
>
> Attachments: OFBiz-3697.patch
>
>
> 1) In case of large database, when there are so many products into the system, then setLastInventoryCount service consider all the products and update records for them.
> 2) So it will keep server busy for some time in every one hour. This logic should be improved.
> 3) Also setLastInventoryCount service does not take facilityId into the account while setting last inventory count in ProductFacility entity.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.