[apache/tvm-rfcs] [RFC][Project API] Extend metadata in ProjectOption (#33)

[Gustavo Romero <no...@github.com.INVALID>]

Hi, could the following RFC be reviewed please?

It is about extending the current metadata associated with project options returned by the Project API.

Thank you.

Cheers,
Gustavo
You can view, comment on, or merge this pull request online at:

  https://github.com/apache/tvm-rfcs/pull/33

-- Commit Summary --

  * [RFC][Project API] Extend metadata in ProjectOption

-- File Changes --

    A rfcs/0020-project_api_extend_metadata.md (252)

-- Patch Links --

https://github.com/apache/tvm-rfcs/pull/33.patch
https://github.com/apache/tvm-rfcs/pull/33.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/33

Re: [apache/tvm-rfcs] [RFC][Project API] Extend metadata in ProjectOption (#33)

[Andrew Reusch <no...@github.com.INVALID>]

Merged #33 into main.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/33#event-5470460565

Re: [apache/tvm-rfcs] [RFC][Project API] Extend metadata in ProjectOption (#33)

[Gustavo Romero <no...@github.com.INVALID>]

cc @areusch @manupa-arm 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/33#issuecomment-918581638

Re: [apache/tvm-rfcs] [RFC][Project API] Extend metadata in ProjectOption (#33)

[Gustavo Romero <no...@github.com.INVALID>]

> @gromero please take a look at the comments here and lmk when it's ready for another review

@areusch Hi. Please take a look. I've also added the text stressing that every option must be associated at least to one API method, as per our discussion last week in the Meetup. Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/33#issuecomment-936978446

Re: [apache/tvm-rfcs] [RFC][Project API] Extend metadata in ProjectOption (#33)

[Andrew Reusch <no...@github.com.INVALID>]

thanks @gromero ! Please open an RFC tracking issue and reference this doc from there.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/33#issuecomment-944382441

Re: [apache/tvm-rfcs] [RFC][Project API] Extend metadata in ProjectOption (#33)

[Gustavo Romero <no...@github.com.INVALID>]

> I apologise for the wall of requested changes @gromero, I've been very nit picky over the clarity of the markdown which I think a find/replace will almost immediately fix the majority of.
>
> Overall this all sounds sensible and makes sense to me as a change.

@Mousius Actually, thanks a lot for the thorough review. I really appreciate it. I'm glad you've spotted the `assert()` bug and the typos. I've addressed all your comments in https://github.com/apache/tvm-rfcs/pull/33/commits/e6ad692b06d1eeedf4d780d97ad75a9b22122ec6  I hope it's all right now. Cheers.
 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/33#issuecomment-923185803

Re: [apache/tvm-rfcs] [RFC][Project API] Extend metadata in ProjectOption (#33)

[Gustavo Romero <no...@github.com.INVALID>]

Thanks a lot for the review @leandron 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/33#issuecomment-920051153

Re: [apache/tvm-rfcs] [RFC][Project API] Extend metadata in ProjectOption (#33)

[Andrew Reusch <no...@github.com.INVALID>]

@gromero please take a look at the comments here and lmk when it's ready for another review

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/33#issuecomment-932994088