You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Stefan Zoerner (JIRA)" <di...@incubator.apache.org> on 2005/09/18 17:12:54 UTC
[jira] Created: (DIREVE-256) Extended operation causes client to hang
Extended operation causes client to hang
----------------------------------------
Key: DIREVE-256
URL: http://issues.apache.org/jira/browse/DIREVE-256
Project: Directory Server
Type: Bug
Components: protocol
Versions: 0.9.3, 0.9.2
Reporter: Stefan Zoerner
Assigned to: Alex Karasulu
Priority: Minor
If a client calls an arbitrary extended operation, the server (namely the ExtendedHandler) throws a NotImplementedException. After this, the call of the client blocks, and the client hangs.
I suggest to change the handler to simply send an error code 2 (LDAP_PROTOCOL_ERROR) with message "Unrecognized extended operation" back to the client. This is the expected behavior if an extended operation is not supported by the server.
Attached you find a test case, which demands an always unknown extended operation (OID=1.1) and checks the result. Error code 2 leads to a CommunicationException in JNDI. I have tested this with several LDAP server implementations, behavior was always as expected.
I have also attached a patch, which changes the ExtendedHandler to behave like described above. Not a big thing, but it leads to compliant behavior for extended ops, even if we do not have any in place yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIREVE-256) Extended operation causes client to hang
Posted by "Stefan Zoerner (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIREVE-256?page=all ]
Stefan Zoerner updated DIREVE-256:
----------------------------------
Attachment: patch_DIREVE-256.txt
A patch which changes class org.apache.ldap.server.protocol.ExtendedHandler to behave as described in the issue.
> Extended operation causes client to hang
> ----------------------------------------
>
> Key: DIREVE-256
> URL: http://issues.apache.org/jira/browse/DIREVE-256
> Project: Directory Server
> Type: Bug
> Components: protocol
> Versions: 0.9.3, 0.9.2
> Reporter: Stefan Zoerner
> Assignee: Alex Karasulu
> Priority: Minor
> Attachments: UnknownExtendedOperationTest.java, patch_DIREVE-256.txt
>
> If a client calls an arbitrary extended operation, the server (namely the ExtendedHandler) throws a NotImplementedException. After this, the call of the client blocks, and the client hangs.
> I suggest to change the handler to simply send an error code 2 (LDAP_PROTOCOL_ERROR) with message "Unrecognized extended operation" back to the client. This is the expected behavior if an extended operation is not supported by the server.
> Attached you find a test case, which demands an always unknown extended operation (OID=1.1) and checks the result. Error code 2 leads to a CommunicationException in JNDI. I have tested this with several LDAP server implementations, behavior was always as expected.
> I have also attached a patch, which changes the ExtendedHandler to behave like described above. Not a big thing, but it leads to compliant behavior for extended ops, even if we do not have any in place yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIREVE-256) Extended operation causes client to hang
Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIREVE-256?page=all ]
Alex Karasulu updated DIREVE-256:
---------------------------------
Fix Version: 0.9.3
Version: (was: 0.9.3)
Thanks Stefan ... updating fix version.
> Extended operation causes client to hang
> ----------------------------------------
>
> Key: DIREVE-256
> URL: http://issues.apache.org/jira/browse/DIREVE-256
> Project: Directory Server
> Type: Bug
> Components: protocol
> Versions: 0.9.2
> Reporter: Stefan Zoerner
> Assignee: Alex Karasulu
> Priority: Minor
> Fix For: 0.9.3
> Attachments: UnknownExtendedOperationTest.java, patch_DIREVE-256.txt
>
> If a client calls an arbitrary extended operation, the server (namely the ExtendedHandler) throws a NotImplementedException. After this, the call of the client blocks, and the client hangs.
> I suggest to change the handler to simply send an error code 2 (LDAP_PROTOCOL_ERROR) with message "Unrecognized extended operation" back to the client. This is the expected behavior if an extended operation is not supported by the server.
> Attached you find a test case, which demands an always unknown extended operation (OID=1.1) and checks the result. Error code 2 leads to a CommunicationException in JNDI. I have tested this with several LDAP server implementations, behavior was always as expected.
> I have also attached a patch, which changes the ExtendedHandler to behave like described above. Not a big thing, but it leads to compliant behavior for extended ops, even if we do not have any in place yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIREVE-256) Extended operation causes client to hang
Posted by "Stefan Zoerner (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIREVE-256?page=all ]
Stefan Zoerner updated DIREVE-256:
----------------------------------
Attachment: UnknownExtendedOperationTest.java
> Extended operation causes client to hang
> ----------------------------------------
>
> Key: DIREVE-256
> URL: http://issues.apache.org/jira/browse/DIREVE-256
> Project: Directory Server
> Type: Bug
> Components: protocol
> Versions: 0.9.3, 0.9.2
> Reporter: Stefan Zoerner
> Assignee: Alex Karasulu
> Priority: Minor
> Attachments: UnknownExtendedOperationTest.java
>
> If a client calls an arbitrary extended operation, the server (namely the ExtendedHandler) throws a NotImplementedException. After this, the call of the client blocks, and the client hangs.
> I suggest to change the handler to simply send an error code 2 (LDAP_PROTOCOL_ERROR) with message "Unrecognized extended operation" back to the client. This is the expected behavior if an extended operation is not supported by the server.
> Attached you find a test case, which demands an always unknown extended operation (OID=1.1) and checks the result. Error code 2 leads to a CommunicationException in JNDI. I have tested this with several LDAP server implementations, behavior was always as expected.
> I have also attached a patch, which changes the ExtendedHandler to behave like described above. Not a big thing, but it leads to compliant behavior for extended ops, even if we do not have any in place yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DIREVE-256) Extended operation causes client to hang
Posted by "Stefan Zoerner (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIREVE-256?page=all ]
Stefan Zoerner closed DIREVE-256:
---------------------------------
Successfully verified. Thank you Alex for applying the patch -- the issue was not that crucial, but it caused my test suite to hang.
> Extended operation causes client to hang
> ----------------------------------------
>
> Key: DIREVE-256
> URL: http://issues.apache.org/jira/browse/DIREVE-256
> Project: Directory Server
> Type: Bug
> Components: protocol
> Versions: 0.9.2
> Reporter: Stefan Zoerner
> Assignee: Alex Karasulu
> Priority: Minor
> Fix For: 0.9.3
> Attachments: UnknownExtendedOperationTest.java, patch_DIREVE-256.txt
>
> If a client calls an arbitrary extended operation, the server (namely the ExtendedHandler) throws a NotImplementedException. After this, the call of the client blocks, and the client hangs.
> I suggest to change the handler to simply send an error code 2 (LDAP_PROTOCOL_ERROR) with message "Unrecognized extended operation" back to the client. This is the expected behavior if an extended operation is not supported by the server.
> Attached you find a test case, which demands an always unknown extended operation (OID=1.1) and checks the result. Error code 2 leads to a CommunicationException in JNDI. I have tested this with several LDAP server implementations, behavior was always as expected.
> I have also attached a patch, which changes the ExtendedHandler to behave like described above. Not a big thing, but it leads to compliant behavior for extended ops, even if we do not have any in place yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DIREVE-256) Extended operation causes client to hang
Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIREVE-256?page=all ]
Alex Karasulu resolved DIREVE-256:
----------------------------------
Resolution: Fixed
Applied and committed patch in revision 291232 here:
http://svn.apache.org/viewcvs.cgi?view=rev&rev=291232
Also added new test case to apache-server main in commit 291234 here:
http://svn.apache.org/viewcvs.cgi?view=rev&rev=291234
> Extended operation causes client to hang
> ----------------------------------------
>
> Key: DIREVE-256
> URL: http://issues.apache.org/jira/browse/DIREVE-256
> Project: Directory Server
> Type: Bug
> Components: protocol
> Versions: 0.9.3, 0.9.2
> Reporter: Stefan Zoerner
> Assignee: Alex Karasulu
> Priority: Minor
> Attachments: UnknownExtendedOperationTest.java, patch_DIREVE-256.txt
>
> If a client calls an arbitrary extended operation, the server (namely the ExtendedHandler) throws a NotImplementedException. After this, the call of the client blocks, and the client hangs.
> I suggest to change the handler to simply send an error code 2 (LDAP_PROTOCOL_ERROR) with message "Unrecognized extended operation" back to the client. This is the expected behavior if an extended operation is not supported by the server.
> Attached you find a test case, which demands an always unknown extended operation (OID=1.1) and checks the result. Error code 2 leads to a CommunicationException in JNDI. I have tested this with several LDAP server implementations, behavior was always as expected.
> I have also attached a patch, which changes the ExtendedHandler to behave like described above. Not a big thing, but it leads to compliant behavior for extended ops, even if we do not have any in place yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira