[GitHub] [pulsar] rdhabalia commented on a change in pull request #5441: [pulsar-perf] record message failure and avoid exiting from process on publish failure

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #5441: [pulsar-perf] record message failure and avoid exiting from process on publish failure
URL: https://github.com/apache/pulsar/pull/5441#discussion_r337773132
 
 

 ##########
 File path: pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java
 ##########
 @@ -497,7 +500,7 @@ private static void runProducer(Arguments arguments,
                         }
                     }).exceptionally(ex -> {
                         log.warn("Write error on message", ex);
-                        System.exit(-1);
+                        messagesFailed.increment();
 
 Review comment:
   > Can we also retain a mode to fail on error?
   
   we can add a flag to continue on failure.. default we can keep it to exit from the process.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services