You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/16 10:10:52 UTC
[GitHub] [incubator-shenyu] hgaol opened a new pull request, #3569: [ISSUE #3556] downgrade curator version to 4.3.0 to compatible with some plugin like sofa
hgaol opened a new pull request, #3569:
URL: https://github.com/apache/incubator-shenyu/pull/3569
<!-- Describe your PR here; eg. Fixes #issueNo -->
For #3556 , all tasks should be finished and the pom should be cleaned. I also changed `zookeeper` dep to `3.5.7` because the curator ver `4.3.0` depends on it. I've tested below functions and they're works well. Welcome to help to test these or others test cases!
- [x] data sync between admin and bootstrap
- [x] register between admin and sofa client
- [x] bootstrap instance
- [x] sofa example works well
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 merged pull request #3569: [ISSUE #3556] downgrade curator version to 4.3.0 to compatible with some plugin like sofa
Posted by GitBox <gi...@apache.org>.
yu199195 merged PR #3569:
URL: https://github.com/apache/incubator-shenyu/pull/3569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3569: [ISSUE #3556] downgrade curator version to 4.3.0 to compatible with some plugin like sofa
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3569:
URL: https://github.com/apache/incubator-shenyu/pull/3569#issuecomment-1157511764
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3569?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3569](https://codecov.io/gh/apache/incubator-shenyu/pull/3569?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84a3649) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/dc2a159e3e3535e70ebf9300c1006ee3a6a37f52?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc2a159) will **increase** coverage by `0.05%`.
> The diff coverage is `63.23%`.
```diff
@@ Coverage Diff @@
## master #3569 +/- ##
============================================
+ Coverage 62.54% 62.59% +0.05%
- Complexity 5562 5566 +4
============================================
Files 848 848
Lines 23465 23491 +26
Branches 2132 2139 +7
============================================
+ Hits 14676 14705 +29
+ Misses 7436 7428 -8
- Partials 1353 1358 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3569?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nyu/register/client/zookeeper/ZookeeperClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50L3NoZW55dS1yZWdpc3Rlci1jbGllbnQtem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0ZXIvY2xpZW50L3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnQuamF2YQ==) | `58.97% <40.00%> (-2.67%)` | :arrow_down: |
| [...u/register/instance/zookeeper/ZookeeperClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItaW5zdGFuY2Uvc2hlbnl1LXJlZ2lzdGVyLWluc3RhbmNlLXpvb2tlZXBlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3JlZ2lzdGVyL2luc3RhbmNlL3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnQuamF2YQ==) | `58.97% <40.00%> (-2.67%)` | :arrow_down: |
| [...ister/client/server/zookeeper/ZookeeperClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50LXNlcnZlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50LXNlcnZlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9yZWdpc3Rlci9jbGllbnQvc2VydmVyL3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnQuamF2YQ==) | `69.23% <66.66%> (-4.75%)` | :arrow_down: |
| [...eeper/ZookeeperClientServerRegisterRepository.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50LXNlcnZlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50LXNlcnZlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9yZWdpc3Rlci9jbGllbnQvc2VydmVyL3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnRTZXJ2ZXJSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `94.59% <90.47%> (-2.24%)` | :arrow_down: |
| [...admin/listener/zookeeper/HttpServiceDiscovery.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbGlzdGVuZXIvem9va2VlcGVyL0h0dHBTZXJ2aWNlRGlzY292ZXJ5LmphdmE=) | `90.32% <100.00%> (+1.61%)` | :arrow_up: |
| [...controller/ShenyuClientHttpRegistryController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TaGVueXVDbGllbnRIdHRwUmVnaXN0cnlDb250cm9sbGVyLmphdmE=) | `77.77% <0.00%> (-22.23%)` | :arrow_down: |
| [...ruptor/RegisterClientServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyQ2xpZW50U2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `52.94% <0.00%> (-11.77%)` | :arrow_down: |
| [...nyu/plugin/motan/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vdGFuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL21vdGFuL2NhY2hlL0FwcGxpY2F0aW9uQ29uZmlnQ2FjaGUuamF2YQ==) | `52.00% <0.00%> (-5.00%)` | :arrow_down: |
| [.../logging/rocketmq/utils/LogCollectConfigUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvdXRpbHMvTG9nQ29sbGVjdENvbmZpZ1V0aWxzLmphdmE=) | `71.11% <0.00%> (-4.45%)` | :arrow_down: |
| [...ng/rocketmq/rocketmq/RocketMQLogCollectClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvcm9ja2V0bXEvUm9ja2V0TVFMb2dDb2xsZWN0Q2xpZW50LmphdmE=) | `74.00% <0.00%> (-2.00%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-shenyu/pull/3569/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3569?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3569?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc2a159...84a3649](https://codecov.io/gh/apache/incubator-shenyu/pull/3569?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org