You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/16 02:57:46 UTC
[GitHub] [skywalking] JohnNiang opened a new pull request #4241: Fix typo:
Update maven update command and description
JohnNiang opened a new pull request #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
typo fix.
- How to fix?
Replace with maven wrapper command and fix compile typo.
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4241:
Fix typo: Update maven update command and description
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#discussion_r367210064
##########
File path: docs/en/guides/How-to-build.md
##########
@@ -133,6 +133,6 @@ Refer to [Build docker image](../../../docker) for more details.
</dependency>
```
5. Run `./mvnw compile -Dmaven.test.skip=true`
-6. Run `maven update`. Must remove the clean projects item before maven update(This will be clear the proto conversion Java file generated by the complie)
+6. Run `./mvnw update`. Must remove the clean projects item before maven update(This will be clear the proto conversion Java file generated by the compile)
Review comment:
`./mvnw update` is not a command.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JaredTan95 commented on a change in pull request
#4241: Fix typo: Update maven update command and description
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on a change in pull request #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#discussion_r367210244
##########
File path: docs/en/guides/How-to-build.md
##########
@@ -133,6 +133,6 @@ Refer to [Build docker image](../../../docker) for more details.
</dependency>
```
5. Run `./mvnw compile -Dmaven.test.skip=true`
-6. Run `maven update`. Must remove the clean projects item before maven update(This will be clear the proto conversion Java file generated by the complie)
+6. Run `./mvnw update`. Must remove the clean projects item before maven update(This will be clear the proto conversion Java file generated by the compile)
Review comment:
may be `./mvnw clean` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JohnNiang commented on issue #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
JohnNiang commented on issue #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#issuecomment-574961934
Thank you for rectification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JohnNiang removed a comment on issue #4241: Fix typo:
Update maven update command and description
Posted by GitBox <gi...@apache.org>.
JohnNiang removed a comment on issue #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#issuecomment-575007201
> > [ERROR] Failed to execute goal io.fabric8:docker-maven-plugin:0.30.0:start (start) on project e2e-mysql: I/O Error: [skyapm/e2e-container:jdk8-1.3] "skywalking-e2e-container-local-single-node-mysql": Timeout after 300399 ms while waiting on url http://localhost:32771/e2e/health-check -> [Help 1]
>
> It looks like oap server container stared failed...
Maybe we shall check the `bin/oapService.sh` bash file because of <https://github.com/apache/skywalking/pull/4241/checks?check_run_id=392573262#step:6:280>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JaredTan95 commented on issue #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on issue #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#issuecomment-575004024
> [ERROR] Failed to execute goal io.fabric8:docker-maven-plugin:0.30.0:start (start) on project e2e-mysql: I/O Error: [skyapm/e2e-container:jdk8-1.3] "skywalking-e2e-container-local-single-node-mysql": Timeout after 300399 ms while waiting on url http://localhost:32771/e2e/health-check -> [Help 1]
It looks like oap server container stared failed...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4241:
Fix typo: Update maven update command and description
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#discussion_r367210447
##########
File path: docs/en/guides/How-to-build.md
##########
@@ -133,6 +133,6 @@ Refer to [Build docker image](../../../docker) for more details.
</dependency>
```
5. Run `./mvnw compile -Dmaven.test.skip=true`
-6. Run `maven update`. Must remove the clean projects item before maven update(This will be clear the proto conversion Java file generated by the complie)
+6. Run `./mvnw update`. Must remove the clean projects item before maven update(This will be clear the proto conversion Java file generated by the compile)
Review comment:
To be honest, I am not sure what does this part mean. As I never use Eclipse these days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JohnNiang closed pull request #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
JohnNiang closed pull request #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JohnNiang commented on issue #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
JohnNiang commented on issue #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#issuecomment-575007201
> > [ERROR] Failed to execute goal io.fabric8:docker-maven-plugin:0.30.0:start (start) on project e2e-mysql: I/O Error: [skyapm/e2e-container:jdk8-1.3] "skywalking-e2e-container-local-single-node-mysql": Timeout after 300399 ms while waiting on url http://localhost:32771/e2e/health-check -> [Help 1]
>
> It looks like oap server container stared failed...
Maybe we shall check the `bin/oapService.sh` bash file because of <https://github.com/apache/skywalking/pull/4241/checks?check_run_id=392573262#step:6:280>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JaredTan95 commented on a change in pull request
#4241: Fix typo: Update maven update command and description
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on a change in pull request #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#discussion_r367210607
##########
File path: docs/en/guides/How-to-build.md
##########
@@ -133,6 +133,6 @@ Refer to [Build docker image](../../../docker) for more details.
</dependency>
```
5. Run `./mvnw compile -Dmaven.test.skip=true`
-6. Run `maven update`. Must remove the clean projects item before maven update(This will be clear the proto conversion Java file generated by the complie)
+6. Run `./mvnw update`. Must remove the clean projects item before maven update(This will be clear the proto conversion Java file generated by the compile)
Review comment:
If so, We should keep it without chenges. :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JaredTan95 commented on issue #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on issue #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#issuecomment-574999328
I re-run the ci.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JaredTan95 commented on issue #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on issue #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#issuecomment-575043825
@JohnNiang you delete your fork? I noted `unknown repository`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#issuecomment-574999205
Is there anything wrong about downloading JDBC driver?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#issuecomment-574998813
Strange, a markdown change makes the CI unstable...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JohnNiang commented on issue #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
JohnNiang commented on issue #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#issuecomment-575047949
> @JohnNiang you delete your fork? I noted `unknown repository`
I will re-request this PR soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JohnNiang opened a new pull request #4241: Fix typo:
Update maven update command and description
Posted by GitBox <gi...@apache.org>.
JohnNiang opened a new pull request #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
typo fix.
- How to fix?
Replace with maven wrapper command and fix compile typo.
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JohnNiang commented on a change in pull request #4241:
Fix typo: Update maven update command and description
Posted by GitBox <gi...@apache.org>.
JohnNiang commented on a change in pull request #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#discussion_r367210511
##########
File path: docs/en/guides/How-to-build.md
##########
@@ -133,6 +133,6 @@ Refer to [Build docker image](../../../docker) for more details.
</dependency>
```
5. Run `./mvnw compile -Dmaven.test.skip=true`
-6. Run `maven update`. Must remove the clean projects item before maven update(This will be clear the proto conversion Java file generated by the complie)
+6. Run `./mvnw update`. Must remove the clean projects item before maven update(This will be clear the proto conversion Java file generated by the compile)
Review comment:
> `./mvnw update` is not a command.
Got it. It's a feature only on Eclipse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JohnNiang closed pull request #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
JohnNiang closed pull request #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JaredTan95 commented on issue #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on issue #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#issuecomment-574962156
199th contributor~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#issuecomment-574999555
> I re-run the ci.
All errors are about no suitable driver of MySQL, but it should be downloaded in CI process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#issuecomment-574960993
You don't need to close, the `compile` is really a typo. Just don't change this command.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#issuecomment-574961454
I revert that part of the change for you. `compile` should be `compiling`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4241: Fix typo: Update
maven update command and description
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4241: Fix typo: Update maven update command and description
URL: https://github.com/apache/skywalking/pull/4241#issuecomment-574968213
> 199th contributor~
Yes, we are closing the 200th. Who will own the honor? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services