[GitHub] [apisix] tokers commented on a diff in pull request #8336: feat: proxy-rewrite support config add set and remove header

[GitBox <gi...@apache.org>]

tokers commented on code in PR #8336:
URL: https://github.com/apache/apisix/pull/8336#discussion_r1023786046


##########
apisix/plugins/proxy-rewrite.lua:
##########
@@ -70,8 +74,58 @@ local schema = {
         },
         headers = {
             description = "new headers for request",
-            type = "object",
-            minProperties = 1,
+            anyOf = {

Review Comment:
   We should use `oneOf`?



##########
apisix/plugins/proxy-rewrite.lua:
##########
@@ -163,6 +163,8 @@ local function check_set_headers(headers)
         if #field == 0 then
             return false, 'invalid field length in header'
         end
+
+        core.log.info("header field: ", field)

Review Comment:
   Why not also show the value?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org