You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Andrzej Bialecki (Jira)" <ji...@apache.org> on 2023/02/07 16:56:00 UTC
[jira] [Updated] (SOLR-16649) Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser
[ https://issues.apache.org/jira/browse/SOLR-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrzej Bialecki updated SOLR-16649:
------------------------------------
Description:
{{Http2SolrClient:800}} calls {{wantStream(...)}} method but passes the wrong argument to it - instead of passing the local {{processor}} arg it uses the instance field {{parser}}.
Throughout this class there's a repeated pattern that easily leads to this confusion - in many methods a local var {{parser}} is created that overshadows the instance field, and then this local {{parser}} is passed around as argument to various operations. However, in this particular method the argument passed from the caller is named differently ({{processor}}) and thus does not overshadow the instance field, which leads to this mistake.
was:
`Http2SolrClient:800` calls `wantStream(...)` method but passes the wrong argument to it - instead of passing the local `processor` arg it uses the instance field `parser`.
Throughout this class there's a repeated pattern that easily leads to this confusion - in many methods a local var `parser` is created that overshadows the instance field, and then this local `parser` is passed around as argument to various operations. However, in this method the argument passed from the caller is named differently (`processor`) and thus does not overshadow the instance field, which leads to this mistake.
> Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser
> ------------------------------------------------------------------------------
>
> Key: SOLR-16649
> URL: https://issues.apache.org/jira/browse/SOLR-16649
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: clients - java
> Affects Versions: main (10.0), 9.1.1
> Reporter: Andrzej Bialecki
> Priority: Major
>
> {{Http2SolrClient:800}} calls {{wantStream(...)}} method but passes the wrong argument to it - instead of passing the local {{processor}} arg it uses the instance field {{parser}}.
> Throughout this class there's a repeated pattern that easily leads to this confusion - in many methods a local var {{parser}} is created that overshadows the instance field, and then this local {{parser}} is passed around as argument to various operations. However, in this particular method the argument passed from the caller is named differently ({{processor}}) and thus does not overshadow the instance field, which leads to this mistake.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org