[GitHub] [airflow] nritholtz opened a new pull request #5940: [AIRFLOW-5336] Add ability to make updating FAB perms on webserver in…

[GitBox <gi...@apache.org>]

nritholtz opened a new pull request #5940: [AIRFLOW-5336] Add ability to make updating FAB perms on webserver in…
URL: https://github.com/apache/airflow/pull/5940
 
 
   …it optional
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   https://issues.apache.org/jira/browse/AIRFLOW-5336
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   Add ability to make updating perms and other syncs on webserver init optional similar to https://github.com/dpgaspar/Flask-AppBuilder/pull/625
   I am running into issues where multiple webserver processes are running what I believe is the sync_perm and it causes there to be records in the ab_permission_view with null permission_id (ultimately resulting in both processes crashing until I either manually clean them up or recreate the table). I envision being able to shut it off on the webserver init and use a one-off run that I am currently using, that handles it as part of deployment via the sync_perm CLI command.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   Not sure if testing is needed here. If it is, let me know where to look.
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services