You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ferruzzi (via GitHub)" <gi...@apache.org> on 2023/03/09 18:34:57 UTC
[GitHub] [airflow] ferruzzi opened a new pull request, #30001: Rename DummyStatsLogger per previous inclusivity push
ferruzzi opened a new pull request, #30001:
URL: https://github.com/apache/airflow/pull/30001
In the past there was a push to remove the word "Dummy" from the codebase for inclusivity reasons. I'm not particularly thrilled with my proposed name `NullStatsLogger`, but I figure I should update this while I'm in here adding the OTel support. Suggestions for a better name are definitely welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a diff in pull request #30001: Rename DummyStatsLogger per previous inclusivity push
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #30001:
URL: https://github.com/apache/airflow/pull/30001#discussion_r1131451904
##########
airflow/stats.py:
##########
@@ -182,8 +182,8 @@ def stop(self, send=True):
self.real_timer.stop()
-class DummyStatsLogger:
- """If no StatsLogger is configured, DummyStatsLogger is used as a fallback."""
+class NullStatsLogger:
+ """If no StatsLogger is configured, NullStatsLogger is used as a fallback."""
Review Comment:
Yeah, I remember that. I don't know if "Empty" really applies in the case but I can't think of one that feels more accurate... in this case the object/class exists, it just doesn't DO anything... If nobody comes up with a better-sounding answer, I'll change it to Empty I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #30001: Rename DummyStatsLogger per previous inclusivity push
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30001:
URL: https://github.com/apache/airflow/pull/30001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #30001: Rename DummyStatsLogger per previous inclusivity push
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #30001:
URL: https://github.com/apache/airflow/pull/30001#discussion_r1131448699
##########
airflow/stats.py:
##########
@@ -182,8 +182,8 @@ def stop(self, send=True):
self.real_timer.stop()
-class DummyStatsLogger:
- """If no StatsLogger is configured, DummyStatsLogger is used as a fallback."""
+class NullStatsLogger:
+ """If no StatsLogger is configured, NullStatsLogger is used as a fallback."""
Review Comment:
last time we had this naming dilemma empty won over null by great length
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #30001: Rename DummyStatsLogger per previous inclusivity push
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on PR #30001:
URL: https://github.com/apache/airflow/pull/30001#issuecomment-1462641589
From a Slack conversation, how do we feel about "NoStatsLogger"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org