You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by cschneider <gi...@git.apache.org> on 2015/11/17 10:50:57 UTC
[GitHub] activemq-artemis pull request: Refactoring.utils
GitHub user cschneider opened a pull request:
https://github.com/apache/activemq-artemis/pull/243
Refactoring.utils
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cschneider/activemq-artemis refactoring.utils
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/243.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #243
----
commit 864620e63a7fce6ce8da9f895992dd23574ec548
Author: Christian Schneider <ch...@die-schneider.net>
Date: 2015-11-17T09:04:04Z
Move FileConfiguration to config.impl
commit 948904fc9dc84c0ecacd638b7536f6025a397793
Author: Christian Schneider <ch...@die-schneider.net>
Date: 2015-11-17T09:50:17Z
Avoid using impls and create config.xml package
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Refactoring.utils
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/243#issuecomment-173391067
This became obsolete. can you close it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Refactoring.utils
Posted by cschneider <gi...@git.apache.org>.
Github user cschneider closed the pull request at:
https://github.com/apache/activemq-artemis/pull/243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Refactoring.utils
Posted by cschneider <gi...@git.apache.org>.
Github user cschneider commented on the pull request:
https://github.com/apache/activemq-artemis/pull/243#issuecomment-159513879
The changes are still valid but not necessary for OSGi at the moment. Unfortunately I found so many other duplications that I gave up on fixing them for near term.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Refactoring.utils
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/243#issuecomment-159425378
This is something we should do on 2.0... the API broke the integration.
Is this still valid after the OSGi is merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix ref to old distribution
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---