You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/29 17:11:55 UTC

[GitHub] [arrow-rs] alamb commented on a change in pull request #240: Improve docs for NullArray, new_null_array and new_empty_array

alamb commented on a change in pull request #240:
URL: https://github.com/apache/arrow-rs/pull/240#discussion_r623241151



##########
File path: arrow/src/array/null.rs
##########
@@ -42,12 +25,33 @@ use crate::array::{Array, ArrayData};
 use crate::datatypes::*;
 
 /// An Array where all elements are nulls
+///

Review comment:
       By moving the description to the struct, the documentation is now on the doc page I would expect (not the module level). Here is what it looks like now:
   
   ![Screen Shot 2021-04-29 at 12 54 51 PM](https://user-images.githubusercontent.com/490673/116590775-24517b00-a8ec-11eb-8843-857ac3f3af68.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org