You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "shaonianxingzhong (via GitHub)" <gi...@apache.org> on 2023/06/02 10:20:19 UTC

[GitHub] [dubbo] shaonianxingzhong commented on a diff in pull request #12406: 多注册中心情况下添加group,拓展cluster找不到invoker url中的对应元数据 fix[issue#12325]

shaonianxingzhong commented on code in PR #12406:
URL: https://github.com/apache/dubbo/pull/12406#discussion_r1214193605


##########
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/directory/AbstractDirectory.java:
##########
@@ -173,6 +174,8 @@ public AbstractDirectory(URL url, RouterChain<T> routerChain, boolean isUrlFromR
                 .setProtocol(consumedProtocol)
                 .setPath(path);
             if (isUrlFromRegistry) {
+                //remove parameters related to register
+                consumerUrlFrom.removeParameter(RegistryConstants.REGISTRY_CLUSTER_KEY);

Review Comment:
   @songxiaosheng 直接在dubbo-demo子工程添加单测还是专门的测试工程?求分享



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org