You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Valentin Valchev (JIRA)" <ji...@apache.org> on 2010/04/12 12:52:40 UTC
[jira] Created: (FELIX-2274) 404 when plugin is missing
404 when plugin is missing
--------------------------
Key: FELIX-2274
URL: https://issues.apache.org/jira/browse/FELIX-2274
Project: Felix
Issue Type: Bug
Components: Web Console
Reporter: Valentin Valchev
Currently the Web Console generates 404 (page not found) error, when a plugin is missing.
But a plugin developer might devicide to show the plugin, only when all required services are available. If the user already opened the web console, the label for such plugin will be rendered. After that, a required service is unregistered and so is the plugin.
At this point, when the user clicks on the label, the Web Console will generate 404.
IMHO, it's will be better, if the web console simply redirects to the default plugin (bundles).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (FELIX-2274) 404 when plugin is missing
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856043#action_12856043 ]
Justin Edelson commented on FELIX-2274:
---------------------------------------
> Well, actually at this point the plugin is not available anymore, so it can't redirect.
Hmmm. You said "a plugin developer might decide to show the plugin..." so why couldn't the plugin developer choose to show a different servlet? But if you're talking about a plugin registered via SCR or Blueprint, this would be more challenging (although not impossible).
>And it's not confusing, because at the top, the bundles tab will be rendered as "selected".
Which will result in "But I asked for the [fill in the blank] plugin!" And they're going to click on the [fill in the blank] button again... and again... and again...
All I'm suggesting is that you have to have some message to the user.
> 404 when plugin is missing
> --------------------------
>
> Key: FELIX-2274
> URL: https://issues.apache.org/jira/browse/FELIX-2274
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Valentin Valchev
>
> Currently the Web Console generates 404 (page not found) error, when a plugin is missing.
> But a plugin developer might devicide to show the plugin, only when all required services are available. If the user already opened the web console, the label for such plugin will be rendered. After that, a required service is unregistered and so is the plugin.
> At this point, when the user clicks on the label, the Web Console will generate 404.
> IMHO, it's will be better, if the web console simply redirects to the default plugin (bundles).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (FELIX-2274) 404 when plugin is missing
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856125#action_12856125 ]
Valentin Valchev commented on FELIX-2274:
-----------------------------------------
Well, you see, the UPnP plugin is visible only when UPnP Service is available. When it's gone - the plugin is also unregistered. This is what I meant for "device to show the plugin.."
You can also think of other situation:
1. the user opens web console and sees a list of plugins, and among them plugin "A"
2. while the user looks at the currently opened plugin, as example "bundles", the plugin "A" is uninstalled
3. although uninstalled, the user still has the plugin "A" rendered in the tabs above, because he didn't refresh the content
4. user clicks on plugin "A"
5. web console generates 404 - because there is no such plugin anymore
it doesn't matter who and how the plugin is unistalled. The point is that the user gets a plain 404 page and cannot navigate to other plugins.
As for the "[fill in the blank]" button - it will no longer be there. It is rendered, only when the plugin is available.
Another possibility, is that Web Console generates a page, that says "plugin A is no longer available, you will be redirected to the default plugin in few seconds", and after that period the user will get to the default plugin, without need to click anything.
> 404 when plugin is missing
> --------------------------
>
> Key: FELIX-2274
> URL: https://issues.apache.org/jira/browse/FELIX-2274
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Valentin Valchev
>
> Currently the Web Console generates 404 (page not found) error, when a plugin is missing.
> But a plugin developer might devicide to show the plugin, only when all required services are available. If the user already opened the web console, the label for such plugin will be rendered. After that, a required service is unregistered and so is the plugin.
> At this point, when the user clicks on the label, the Web Console will generate 404.
> IMHO, it's will be better, if the web console simply redirects to the default plugin (bundles).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (FELIX-2274) 404 when plugin is missing
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856128#action_12856128 ]
Justin Edelson commented on FELIX-2274:
---------------------------------------
> Another possibility, is that Web Console generates a page, that says "plugin A is no longer available, you will be redirected to the default plugin in few
> seconds", and after that period the user will get to the default plugin, without need to click anything.
This is a good solution.
> 404 when plugin is missing
> --------------------------
>
> Key: FELIX-2274
> URL: https://issues.apache.org/jira/browse/FELIX-2274
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Valentin Valchev
>
> Currently the Web Console generates 404 (page not found) error, when a plugin is missing.
> But a plugin developer might devicide to show the plugin, only when all required services are available. If the user already opened the web console, the label for such plugin will be rendered. After that, a required service is unregistered and so is the plugin.
> At this point, when the user clicks on the label, the Web Console will generate 404.
> IMHO, it's will be better, if the web console simply redirects to the default plugin (bundles).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (FELIX-2274) 404 when plugin is missing
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856038#action_12856038 ]
Valentin Valchev commented on FELIX-2274:
-----------------------------------------
Well, actually at this point the plugin is not available anymore, so it can't redirect.
And it's not confusing, because at the top, the bundles tab will be rendered as "selected".
> 404 when plugin is missing
> --------------------------
>
> Key: FELIX-2274
> URL: https://issues.apache.org/jira/browse/FELIX-2274
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Valentin Valchev
>
> Currently the Web Console generates 404 (page not found) error, when a plugin is missing.
> But a plugin developer might devicide to show the plugin, only when all required services are available. If the user already opened the web console, the label for such plugin will be rendered. After that, a required service is unregistered and so is the plugin.
> At this point, when the user clicks on the label, the Web Console will generate 404.
> IMHO, it's will be better, if the web console simply redirects to the default plugin (bundles).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (FELIX-2274) 404 when plugin is missing
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Valchev updated FELIX-2274:
------------------------------------
Attachment: 404.patch
The attached patch instead of sending 404 error, sends the 404 status but also generates an HTML page that forwards to the main webconsole.
The 404 page is localized in English & Bulgarian. Missing German localization.
> 404 when plugin is missing
> --------------------------
>
> Key: FELIX-2274
> URL: https://issues.apache.org/jira/browse/FELIX-2274
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Valentin Valchev
> Assignee: Valentin Valchev
> Attachments: 404.patch
>
>
> Currently the Web Console generates 404 (page not found) error, when a plugin is missing.
> But a plugin developer might devicide to show the plugin, only when all required services are available. If the user already opened the web console, the label for such plugin will be rendered. After that, a required service is unregistered and so is the plugin.
> At this point, when the user clicks on the label, the Web Console will generate 404.
> IMHO, it's will be better, if the web console simply redirects to the default plugin (bundles).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (FELIX-2274) 404 when plugin is missing
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Valchev resolved FELIX-2274.
-------------------------------------
Assignee: Valentin Valchev (was: Felix Meschberger)
Resolution: Fixed
added German localization (10x to my colleagues from Cologne)
> 404 when plugin is missing
> --------------------------
>
> Key: FELIX-2274
> URL: https://issues.apache.org/jira/browse/FELIX-2274
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Valentin Valchev
> Assignee: Valentin Valchev
> Fix For: webconsole-3.0.2
>
> Attachments: 404.patch
>
>
> Currently the Web Console generates 404 (page not found) error, when a plugin is missing.
> But a plugin developer might devicide to show the plugin, only when all required services are available. If the user already opened the web console, the label for such plugin will be rendered. After that, a required service is unregistered and so is the plugin.
> At this point, when the user clicks on the label, the Web Console will generate 404.
> IMHO, it's will be better, if the web console simply redirects to the default plugin (bundles).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (FELIX-2274) 404 when plugin is missing
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Valchev updated FELIX-2274:
------------------------------------
Assignee: Felix Meschberger (was: Valentin Valchev)
> 404 when plugin is missing
> --------------------------
>
> Key: FELIX-2274
> URL: https://issues.apache.org/jira/browse/FELIX-2274
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Valentin Valchev
> Assignee: Felix Meschberger
> Fix For: webconsole-3.0.2
>
> Attachments: 404.patch
>
>
> Currently the Web Console generates 404 (page not found) error, when a plugin is missing.
> But a plugin developer might devicide to show the plugin, only when all required services are available. If the user already opened the web console, the label for such plugin will be rendered. After that, a required service is unregistered and so is the plugin.
> At this point, when the user clicks on the label, the Web Console will generate 404.
> IMHO, it's will be better, if the web console simply redirects to the default plugin (bundles).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (FELIX-2274) 404 when plugin is missing
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856867#action_12856867 ]
Valentin Valchev commented on FELIX-2274:
-----------------------------------------
Patch committed. However no German localization is added.
Felix, can you add it and mark the issue fixed?
> 404 when plugin is missing
> --------------------------
>
> Key: FELIX-2274
> URL: https://issues.apache.org/jira/browse/FELIX-2274
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Valentin Valchev
> Assignee: Valentin Valchev
> Fix For: webconsole-3.0.2
>
> Attachments: 404.patch
>
>
> Currently the Web Console generates 404 (page not found) error, when a plugin is missing.
> But a plugin developer might devicide to show the plugin, only when all required services are available. If the user already opened the web console, the label for such plugin will be rendered. After that, a required service is unregistered and so is the plugin.
> At this point, when the user clicks on the label, the Web Console will generate 404.
> IMHO, it's will be better, if the web console simply redirects to the default plugin (bundles).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (FELIX-2274) 404 when plugin is missing
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Valchev reassigned FELIX-2274:
---------------------------------------
Assignee: Valentin Valchev
> 404 when plugin is missing
> --------------------------
>
> Key: FELIX-2274
> URL: https://issues.apache.org/jira/browse/FELIX-2274
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Valentin Valchev
> Assignee: Valentin Valchev
>
> Currently the Web Console generates 404 (page not found) error, when a plugin is missing.
> But a plugin developer might devicide to show the plugin, only when all required services are available. If the user already opened the web console, the label for such plugin will be rendered. After that, a required service is unregistered and so is the plugin.
> At this point, when the user clicks on the label, the Web Console will generate 404.
> IMHO, it's will be better, if the web console simply redirects to the default plugin (bundles).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (FELIX-2274) 404 when plugin is missing
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856019#action_12856019 ]
Justin Edelson commented on FELIX-2274:
---------------------------------------
IMHO, this seems like confusing behavior. If a plugin developer wanted to do this, couldn't they just do it with response.sendRedirect() ?
> 404 when plugin is missing
> --------------------------
>
> Key: FELIX-2274
> URL: https://issues.apache.org/jira/browse/FELIX-2274
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Valentin Valchev
>
> Currently the Web Console generates 404 (page not found) error, when a plugin is missing.
> But a plugin developer might devicide to show the plugin, only when all required services are available. If the user already opened the web console, the label for such plugin will be rendered. After that, a required service is unregistered and so is the plugin.
> At this point, when the user clicks on the label, the Web Console will generate 404.
> IMHO, it's will be better, if the web console simply redirects to the default plugin (bundles).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira