You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/06 14:37:52 UTC
[GitHub] [airflow] potiuk opened a new pull request #22026: Fix failing main after merging SFTP hook test connection
potiuk opened a new pull request #22026:
URL: https://github.com/apache/airflow/pull/22026
The #21997 implemented test_connection method in FTP hook, but
we were using FTP hook to actually test .... what happens
when the test_connection method was missing :)
Unfortunately the test for it was not run because the "core"
tests are skipped in case only provider change :(.
This PR switches the test_connection missing test to use GRPC hook
(it does not have the test_connection method) and moves the whole
test_connection.py to "always" category of tests that are
always executed - there are more tests there that have some
assumptions on the existing connections and having the tests
executed "always" makes sense to avoid similar problems in the
future.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #22026: Fix failing main after merging SFTP hook test connection
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #22026:
URL: https://github.com/apache/airflow/pull/22026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22026: Fix failing main after merging SFTP hook test connection
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22026:
URL: https://github.com/apache/airflow/pull/22026#issuecomment-1059978592
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org