[GitHub] keith-turner commented on a change in pull request #793: Cleanup TabletServerLogger

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #793: Cleanup TabletServerLogger
URL: https://github.com/apache/accumulo/pull/793#discussion_r240390031
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
 ##########
 @@ -1388,18 +1400,22 @@ private void writeConditionalMutations(Map<KeyExtent,List<ServerConditionalMutat
                 } else {
                   for (ServerConditionalMutation scm : entry.getValue())
                     results.add(new TCMResult(scm.getID(), TCMStatus.ACCEPTED));
-                  sendables.put(cs,
-                      new Mutations(
-                          DurabilityImpl.resolveDurabilty(sess.durability, tabletDurability),
-                          mutations));
+                  if (durability != Durability.NONE) {
+                    loggables.put(cs, new TabletMutations(cs.getLogId(), cs.getWALogSeq(),
+                        mutations, durability));
+                  }
+                  sendables.put(cs, new Mutations(durability, mutations));
                 }
               }
             } catch (TConstraintViolationException e) {
+              CommitSession cs = e.getCommitSession();
 
 Review comment:
   This line and the following one could be moved inside the if stmt

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services