[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #5051: Micrometer: Message History factory and JMX MicrometerMessageHistory is not covered

["jamesnetherton (via GitHub)" <gi...@apache.org>]

jamesnetherton commented on code in PR #5051:
URL: https://github.com/apache/camel-quarkus/pull/5051#discussion_r1251954876


##########
extensions/micrometer/runtime/src/main/doc/limitations.adoc:
##########
@@ -6,3 +6,9 @@ The `Exposing Micrometer statisctics in JMX` action is not available in native m
 
 Prometheus backend ignores negative values during increment of Counter metrics.
 
+=== Exposing statistics in JMX ===
+
+Micrometer extension leverages the Quarkus Micrometer extension. There is a difference in registering JMX registries (compared to the camel https://camel.apache.org/components/3.20.x/micrometer-component.html#_exposing_micrometer_statistics_in_jmx[doc]).

Review Comment:
   Please use the `xref` style to link to the component docs.



##########
extensions/micrometer/runtime/src/main/doc/limitations.adoc:
##########
@@ -6,3 +6,9 @@ The `Exposing Micrometer statisctics in JMX` action is not available in native m
 
 Prometheus backend ignores negative values during increment of Counter metrics.
 
+=== Exposing statistics in JMX ===
+
+Micrometer extension leverages the Quarkus Micrometer extension. There is a difference in registering JMX registries (compared to the camel https://camel.apache.org/components/3.20.x/micrometer-component.html#_exposing_micrometer_statistics_in_jmx[doc]).
+
+Once the JMX dependency (`io.micrometer:micrometer-registry-jmx`) is added, Quarkus detects it, and creates a JMX registry with domain name `metrics`. Manual creation of JMX registry is not required.

Review Comment:
   Should we mention `io.quarkiverse.micrometer.registry:quarkus-micrometer-registry-jmx` instead of the plain `io.micrometer` one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org