[GitHub] [zeppelin] Reamer commented on a diff in pull request #4336: [ZEPPELIN-5699] Trim space in ConfInterpreter

[GitBox <gi...@apache.org>]

Reamer commented on code in PR #4336:
URL: https://github.com/apache/zeppelin/pull/4336#discussion_r844728595


##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/ConfInterpreter.java:
##########
@@ -67,6 +67,9 @@ public InterpreterResult interpret(String st, InterpreterContext context)
       finalProperties.putAll(getProperties());
       Properties newProperties = new Properties();
       newProperties.load(new StringReader(st));
+      for (String key : newProperties.stringPropertyNames()) {

Review Comment:
   I mean the following situation.
   `newProperties.load(new StringReader(st));` loads the following property:
   ```
   'myproperty       ': 'test'
   ```
   Afterwards `newProperties` contains the following values:
   ```
   'myproperty       ': 'testValue'`
   'myproperty': 'testValue'
   ```
   Now you have two property keys, one with spaces and one without.
   Is this intentional?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org