You are viewing a plain text version of this content. The canonical link for it is here.

Posted to codereview@trafodion.apache.org by hegdean <gi...@git.apache.org> on 2018/03/13 17:27:16 UTC

[GitHub] trafodion pull request #1472: [TRAFODION-2958] Consolidate the master and ba...

GitHub user hegdean opened a pull request:

    https://github.com/apache/trafodion/pull/1472

    [TRAFODION-2958] Consolidate the master and backup files in dcs conf folder to a single file (masters)

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hegdean/trafodion dcschanges

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafodion/pull/1472.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1472
    
----
commit 2f48d0734fcdd112b6bcca56a1fef27333b1d004
Author: Anuradha Hegde <an...@...>
Date:   2018-03-13T02:23:30Z

    [TRAFODION-2958] Consolidate the master and backup files in dcs conf folder to a single file (masters)

commit 6a0bcd9d7bdeece8bb962dfcbc2ecff1daf106c8
Author: Anuradha Hegde <an...@...>
Date:   2018-03-13T02:24:57Z

    Merge branch 'master' of github.com:apache/trafodion into dcschanges

----


---

[GitHub] trafodion pull request #1472: [TRAFODION-2958] Consolidate the master and ba...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/trafodion/pull/1472


---

[GitHub] trafodion pull request #1472: [TRAFODION-2958] Consolidate the master and ba...

Posted by DaveBirdsall <gi...@git.apache.org>.

Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1472#discussion_r174271812
  
    --- Diff: core/sqf/sql/scripts/dcscheck ---
    @@ -73,14 +72,14 @@ if ( [ $sq_stat == 0 ] || [ $sq_stat == 1 ] ); then
     
     ### Get the configured primary node for DcsMaster
       if [ -s ${DCS_INSTALL_DIR}/conf/master ]; then
    --- End diff --
    
    Should this statement be changed to conf/masters? If not, should this "if" be deleted?


---

[GitHub] trafodion pull request #1472: [TRAFODION-2958] Consolidate the master and ba...

Posted by hegdean <gi...@git.apache.org>.

Github user hegdean commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1472#discussion_r174276113
  
    --- Diff: core/sqf/sql/scripts/dcscheck ---
    @@ -73,14 +72,14 @@ if ( [ $sq_stat == 0 ] || [ $sq_stat == 1 ] ); then
     
     ### Get the configured primary node for DcsMaster
       if [ -s ${DCS_INSTALL_DIR}/conf/master ]; then
    --- End diff --
    
    Yes this should be deleted. will take care of it . Thanks


---