You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2014/11/17 13:54:18 UTC
[GitHub] incubator-brooklyn pull request: Use Guava Maps/Lists classes rath...
GitHub user sjcorbett opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/339
Use Guava Maps/Lists classes rather than TestNG
`RebindTestUtils` throws `NoSuchMethodError` on `Maps.newLinkedHashMap` when working on a project using an older version of TestNG. Will wait for asfbot before merging.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/incubator-brooklyn import
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/339.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #339
----
commit e06a2a826db2f298aa1e18952bbd5a3dc38980ce
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2014-11-17T12:30:05Z
Use Guava Maps/Lists classes rather than TestNG
commit 8d30806c451932be1fc9efa4a5ea984cc0bedee5
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2014-11-17T12:54:07Z
Clarify LocalManagementContextForTests exception message
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Use Guava Maps/Lists classes rath...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/339#issuecomment-63302926
`org.testng.collections.Maps.newLinkedHashMap` does not exist in older versions of TestNG, so other projects that are not up to date cannot use `RebindTestUtils`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Use Guava Maps/Lists classes rath...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/339#issuecomment-63302346
Obvious. Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Use Guava Maps/Lists classes rath...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/339
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Use Guava Maps/Lists classes rath...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/339#issuecomment-63302993
@grkvlt Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Use Guava Maps/Lists classes rath...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/339#issuecomment-63302890
All tests pass, the build failed due to a timeout on Brooklyn QA, so merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Use Guava Maps/Lists classes rath...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/339#issuecomment-63604745
@sjcorbett OK, i thought you meant the *Guava* version of `Maps.newLinkedHashMap` was causing problems. Understand now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---