[GitHub] [solr] HoustonPutman commented on a diff in pull request #1363: SOLR-16664: TestCoordinatorRole fails docs is null

["HoustonPutman (via GitHub)" <gi...@apache.org>]

HoustonPutman commented on code in PR #1363:
URL: https://github.com/apache/solr/pull/1363#discussion_r1112612047


##########
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##########
@@ -389,6 +390,7 @@ private String getHostCoreName(
     SolrQuery q = new SolrQuery("*:*");
     q.add("fl", "id,desc_s,_core_:[core]").add(OMIT_HEADER, TRUE);
     p.accept(q);
+    // TODO why is this building a string instead of using the proper SolrClient???

Review Comment:
   Are you sure you don't mean `CloudHttp2SolrClient`? I don't think that the `Http2SolrClient` should know anything about the cloud topology.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org