You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2012/10/06 04:20:02 UTC
[jira] [Created] (HDFS-4014) Fix warnings found by findbugs2
Eli Collins created HDFS-4014:
---------------------------------
Summary: Fix warnings found by findbugs2
Key: HDFS-4014
URL: https://issues.apache.org/jira/browse/HDFS-4014
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.0.0-alpha
Reporter: Eli Collins
Assignee: Eli Collins
The HDFS side of HADOOP-8594. Ubrella jira for fixing the warnings found by findbugs 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4014) Fix warnings found by findbugs2
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476678#comment-13476678 ]
Eli Collins commented on HDFS-4014:
-----------------------------------
Arun, Sanjay,
I only pulled out the noteworthy ones to separate jiras to make them easier to review, there are 7 patches but they fix over 70 issues, eg I didn't want to make a pretty key change like changing the type of generation stamp (HDFS-4029) with a bunch of other trivial fixes. Also, some may need to wait to go in until we actually upgrade to findbugs 2, while some can go in now, so if you don't mind I'll commit each independently rather than maintain one big patch for a long time. You can remove yourself as a watcher from the individual jiras if you don't want to see the commit traffic.
Thanks,
Eli
> Fix warnings found by findbugs2
> --------------------------------
>
> Key: HDFS-4014
> URL: https://issues.apache.org/jira/browse/HDFS-4014
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
>
> The HDFS side of HADOOP-8594. Ubrella jira for fixing the warnings found by findbugs 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4014) Fix warnings found by findbugs2
Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476403#comment-13476403 ]
Sanjay Radia commented on HDFS-4014:
------------------------------------
bq. Eli - can we please open a single jira to fix findbugs warnings? Why bother with so much noise? Thanks.
+1 - lets keep the noise low - a single patch per project should be good enough.
BTW ELi, thanks for doing this thankless task.
> Fix warnings found by findbugs2
> --------------------------------
>
> Key: HDFS-4014
> URL: https://issues.apache.org/jira/browse/HDFS-4014
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
>
> The HDFS side of HADOOP-8594. Ubrella jira for fixing the warnings found by findbugs 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4014) Fix warnings found by findbugs2
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478483#comment-13478483 ]
Tsz Wo (Nicholas), SZE commented on HDFS-4014:
----------------------------------------------
This findbugs 2 warnings for GenerationStamp, excessBlocksCount and postponedMisreplicatedBlocksCount are false positives. GenerationStamp and many other namenode/blockmanagement classes such as INode, Block, Lease, etc. are synchronized by the namesystem lock. If we synchronize all these classes individually, it definitely hurts performance.
> Fix warnings found by findbugs2
> --------------------------------
>
> Key: HDFS-4014
> URL: https://issues.apache.org/jira/browse/HDFS-4014
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
>
> The HDFS side of HADOOP-8594. Ubrella jira for fixing the warnings found by findbugs 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4014) Fix warnings found by findbugs2
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473725#comment-13473725 ]
Eli Collins commented on HDFS-4014:
-----------------------------------
With the patches for all the sub-tasks of this jira findbugs 2 is clean. If I can figure out a way to update HDFS to the latest version w/o affecting the other projects I'll do that. Would be great for someone to tackle the common, mr and yarn side as well.
> Fix warnings found by findbugs2
> --------------------------------
>
> Key: HDFS-4014
> URL: https://issues.apache.org/jira/browse/HDFS-4014
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
>
> The HDFS side of HADOOP-8594. Ubrella jira for fixing the warnings found by findbugs 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4014) Fix warnings found by findbugs2
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476398#comment-13476398 ]
Arun C Murthy commented on HDFS-4014:
-------------------------------------
Eli - can we please open a *single* jira to fix findbugs warnings? Why bother with so much noise? Thanks.
> Fix warnings found by findbugs2
> --------------------------------
>
> Key: HDFS-4014
> URL: https://issues.apache.org/jira/browse/HDFS-4014
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
>
> The HDFS side of HADOOP-8594. Ubrella jira for fixing the warnings found by findbugs 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4014) Fix warnings found by findbugs2
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478562#comment-13478562 ]
Eli Collins commented on HDFS-4014:
-----------------------------------
Nicholas, checkout the patches, eg for HDFS-4035, note that the patches do not eg synchronize all these classes individually.
> Fix warnings found by findbugs2
> --------------------------------
>
> Key: HDFS-4014
> URL: https://issues.apache.org/jira/browse/HDFS-4014
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
>
> The HDFS side of HADOOP-8594. Ubrella jira for fixing the warnings found by findbugs 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira