You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/10/11 21:06:21 UTC
[GitHub] [pinot] deemoliu opened a new pull request #7559: Make dim tables creation bypass tenant validation
deemoliu opened a new pull request #7559:
URL: https://github.com/apache/pinot/pull/7559
issue #7549
## Description
<!-- Add a description of your PR here.
A good description should include pointers to an issue or design document, etc.
-->
For Pinot lookup join feature, we need to create dim table in the same tenant of the fact time, and the dim table need to be created in all the hosts.
The current behavior is that,
- the dim table is a offline table
- the validation validate if there is a offline tagged host in the tenant
- if the fact table is a realtime table, the dim table need to be deployed to the realtime tenant with at least one offline host.
This PR updated the validation to bypass the above tag validation for dim table.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
<!-- If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #7559: Make dim tables creation bypass tenant validation
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #7559:
URL: https://github.com/apache/pinot/pull/7559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] chenboat commented on a change in pull request #7559: Make dim tables creation bypass tenant validation
Posted by GitBox <gi...@apache.org>.
chenboat commented on a change in pull request #7559:
URL: https://github.com/apache/pinot/pull/7559#discussion_r727334576
##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1294,7 +1294,7 @@ void validateTableTenantConfig(TableConfig tableConfig) {
tagsToCheck.add(completedServerTag);
}
for (String tag : tagsToCheck) {
- if (getInstancesWithTag(tag).isEmpty()) {
+ if (!tableConfig.isDimTable() && getInstancesWithTag(tag).isEmpty()) {
Review comment:
Please double check and add unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] chenboat commented on a change in pull request #7559: Make dim tables creation bypass tenant validation
Posted by GitBox <gi...@apache.org>.
chenboat commented on a change in pull request #7559:
URL: https://github.com/apache/pinot/pull/7559#discussion_r727334576
##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1294,7 +1294,7 @@ void validateTableTenantConfig(TableConfig tableConfig) {
tagsToCheck.add(completedServerTag);
}
for (String tag : tagsToCheck) {
- if (getInstancesWithTag(tag).isEmpty()) {
+ if (!tableConfig.isDimTable() && getInstancesWithTag(tag).isEmpty()) {
Review comment:
Please double check and add unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] deemoliu commented on pull request #7559: Make dim tables creation bypass tenant validation
Posted by GitBox <gi...@apache.org>.
deemoliu commented on pull request #7559:
URL: https://github.com/apache/pinot/pull/7559#issuecomment-940440240
cc: @yupeng9 @chenboat @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org