[GitHub] [apisix] spacewander commented on a change in pull request #3993: change(prometheus): redesign the latency metrics & update grafana

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #3993:
URL: https://github.com/apache/apisix/pull/3993#discussion_r608384672



##########
File path: docs/en/latest/plugins/prometheus.md
##########
@@ -151,27 +153,17 @@ Or you can goto [Grafana official](https://grafana.com/grafana/dashboards/11719)
 * `etcd reachability`: A gauge type with a value of 0 or 1, representing if etcd can be reached by a APISIX or not, where `1` is available, and `0` is unavailable.
 * `Connections`: Various Nginx connection metrics like active, reading, writing, and number of accepted connections.
 * `Batch process entries`: A gauge type, when we use plugins and the plugin used batch process to send data, such as: sys logger, http logger, sls logger, tcp logger, udp logger and zipkin, then the entries which hasn't been sent in batch process will be counted in the metrics.
-* `Latency`: The per service histogram of request time and the overhead added by APISIX (request time - upstream response time).
+* `Latency`: The per service histogram of request time in different dimensions.
 
     Attributes：
 
     | Name      | Description |
     | ----------| ------------- |
-    | type      | Its value is fixed as `request`, which means HTTP request. |
+    | type      | The optional values are `apisix`, `upstream` and `request`, which means http latency caused by apisix, upstream, and in total. |

Review comment:
       "The value can be `apisix`, `upstream` or `request`, which means http latency caused by apisix, upstream, or their sum." would be better?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org