You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by David Chen <dc...@linkedin.com> on 2014/05/29 21:33:24 UTC
Re: Review Request 22033: HIVE-7094: Separate static and dynamic
partitioning implementations from FileRecordWriterContainer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22033/
-----------------------------------------------------------
(Updated May 29, 2014, 7:33 p.m.)
Review request for hive.
Summary (updated)
-----------------
HIVE-7094: Separate static and dynamic partitioning implementations from FileRecordWriterContainer.
Bugs: HIVE-7094
https://issues.apache.org/jira/browse/HIVE-7094
Repository: hive-git
Description
-------
HIVE-7093: Separate static and dynamic partitioning implementations from FileRecordWriterContainer.
Diffs
-----
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DynamicFileRecordWriterContainer.java PRE-CREATION
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputFormatContainer.java e9ca263abade20b7423ad98695807a60ab957ead
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileRecordWriterContainer.java b55a05528d5a4eed114b5628697cf5a60f6c6cbc
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/StaticFileRecordWriterContainer.java PRE-CREATION
Diff: https://reviews.apache.org/r/22033/diff/
Testing
-------
Thanks,
David Chen
Re: Review Request 22033: HIVE-7094: Separate static and dynamic
partitioning implementations from FileRecordWriterContainer.
Posted by David Chen <dc...@linkedin.com>.
> On June 12, 2014, 9:19 p.m., Carl Steinbach wrote:
> > hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DynamicFileRecordWriterContainer.java, line 58
> > <https://reviews.apache.org/r/22033/diff/1/?file=598889#file598889line58>
> >
> > Is this the result of automated formatting or something that you're doing by hand?
I formatted this by hand because it is more readable to me this way.
> On June 12, 2014, 9:19 p.m., Carl Steinbach wrote:
> > hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/StaticFileRecordWriterContainer.java, line 34
> > <https://reviews.apache.org/r/22033/diff/1/?file=598892#file598892line34>
> >
> > Please make it clear in the comment that "static" refers to static partitions. Also, does it make sense to change the name to StaticPartitionFileRecordWriterContainer? Extremely verbose but it gets the point across and avoids confusion.
I have updated the comments. That is a good idea. I have renamed the two classes to StaticPartitionFileRecordWriterContainer and DynamicPartitionFileRecordWriterContainer.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22033/#review45537
-----------------------------------------------------------
On May 29, 2014, 7:33 p.m., David Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22033/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 7:33 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7094
> https://issues.apache.org/jira/browse/HIVE-7094
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-7093: Separate static and dynamic partitioning implementations from FileRecordWriterContainer.
>
>
> Diffs
> -----
>
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DynamicFileRecordWriterContainer.java PRE-CREATION
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputFormatContainer.java e9ca263abade20b7423ad98695807a60ab957ead
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileRecordWriterContainer.java b55a05528d5a4eed114b5628697cf5a60f6c6cbc
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/StaticFileRecordWriterContainer.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22033/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Chen
>
>
Re: Review Request 22033: HIVE-7094: Separate static and dynamic
partitioning implementations from FileRecordWriterContainer.
Posted by Carl Steinbach <cw...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22033/#review45537
-----------------------------------------------------------
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DynamicFileRecordWriterContainer.java
<https://reviews.apache.org/r/22033/#comment80380>
Please make it clear in the comment that "dynamic" refers to dynamic partitions.
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DynamicFileRecordWriterContainer.java
<https://reviews.apache.org/r/22033/#comment80381>
Is this the result of automated formatting or something that you're doing by hand?
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/StaticFileRecordWriterContainer.java
<https://reviews.apache.org/r/22033/#comment80382>
Please make it clear in the comment that "static" refers to static partitions. Also, does it make sense to change the name to StaticPartitionFileRecordWriterContainer? Extremely verbose but it gets the point across and avoids confusion.
- Carl Steinbach
On May 29, 2014, 7:33 p.m., David Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22033/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 7:33 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7094
> https://issues.apache.org/jira/browse/HIVE-7094
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-7093: Separate static and dynamic partitioning implementations from FileRecordWriterContainer.
>
>
> Diffs
> -----
>
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DynamicFileRecordWriterContainer.java PRE-CREATION
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputFormatContainer.java e9ca263abade20b7423ad98695807a60ab957ead
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileRecordWriterContainer.java b55a05528d5a4eed114b5628697cf5a60f6c6cbc
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/StaticFileRecordWriterContainer.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22033/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Chen
>
>
Re: Review Request 22033: HIVE-7094: Separate static and dynamic
partitioning implementations from FileRecordWriterContainer.
Posted by David Chen <dc...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22033/
-----------------------------------------------------------
(Updated June 18, 2014, 7:37 p.m.)
Review request for hive.
Bugs: HIVE-7094
https://issues.apache.org/jira/browse/HIVE-7094
Repository: hive-git
Description
-------
HIVE-7094: Separate static and dynamic partitioning implementations from FileRecordWriterContainer.
Diffs (updated)
-----
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DynamicPartitionFileRecordWriterContainer.java PRE-CREATION
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputFormatContainer.java e9ca263abade20b7423ad98695807a60ab957ead
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileRecordWriterContainer.java b55a05528d5a4eed114b5628697cf5a60f6c6cbc
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/StaticPartitionFileRecordWriterContainer.java PRE-CREATION
Diff: https://reviews.apache.org/r/22033/diff/
Testing
-------
Thanks,
David Chen
Re: Review Request 22033: HIVE-7094: Separate static and dynamic
partitioning implementations from FileRecordWriterContainer.
Posted by David Chen <dc...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22033/
-----------------------------------------------------------
(Updated June 13, 2014, 1:14 a.m.)
Review request for hive.
Changes
-------
Address review comments.
Bugs: HIVE-7094
https://issues.apache.org/jira/browse/HIVE-7094
Repository: hive-git
Description (updated)
-------
HIVE-7094: Separate static and dynamic partitioning implementations from FileRecordWriterContainer.
Diffs (updated)
-----
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DynamicPartitionFileRecordWriterContainer.java PRE-CREATION
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputFormatContainer.java e9ca263abade20b7423ad98695807a60ab957ead
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileRecordWriterContainer.java b55a05528d5a4eed114b5628697cf5a60f6c6cbc
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/StaticPartitionFileRecordWriterContainer.java PRE-CREATION
Diff: https://reviews.apache.org/r/22033/diff/
Testing
-------
Thanks,
David Chen