[Bug 63201] New: SearchTreeDialog disappears behind master JFrame

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=63201

            Bug ID: 63201
           Summary: SearchTreeDialog disappears behind master JFrame
           Product: JMeter
           Version: 5.1
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: benoit.vatan@gmail.com
  Target Milestone: JMETER_5.2

In JMeter GUI, when searching in the tree using Ctrl+F and the
SearchTreeDialog, the dialog disappears behind JMeter JFrame if focus is
tranfered to the JFrame for some reason (by clicking in the tree for example).

This is because the SearchTreeDialog has no parent.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 63201] SearchTreeDialog disappears behind master JFrame

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=63201

Felix Schumacher <fe...@internetallee.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
           Keywords|                            |FixedInTrunk
         Resolution|---                         |FIXED

--- Comment #2 from Felix Schumacher <fe...@internetallee.de> ---
Thanks for the great description and patch. The fix will be included in the
next version of JMeter.

One minor thing, instanceof is true only if the object is not null.

Date: Fri Feb 22 19:49:30 2019
New Revision: 1854171

URL: http://svn.apache.org/viewvc?rev=1854171&view=rev
Log:
SearchTreeDialog disappears behind master JFrame

Contributed by Benoit Vatan (benoit.vatan at gmail.com)
Bugzilla Id: 63201

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeCommand.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeDialog.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 63201] SearchTreeDialog disappears behind master JFrame

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=63201

Benoit Vatan <be...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benoit.vatan@gmail.com

--- Comment #1 from Benoit Vatan <be...@gmail.com> ---
Created attachment 36454
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36454&action=edit
Add parent to SearchTreeDialog

Suggested patch for fixing. Tested on Linux with Java 1.8.0_121.
Set a parent on SearchTreeDialog from SearchTreeCommand whose code had to be
enhanced to retrieve the master JFrame that is not directly exposed.

-- 
You are receiving this mail because:
You are the assignee for the bug.