[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1221: DISPATCH-1986: Retry creating TestServer instance if port is already …

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #1221:
URL: https://github.com/apache/qpid-dispatch/pull/1221#discussion_r634392753



##########
File path: tests/http1_tests.py
##########
@@ -367,6 +366,27 @@ def check_response(self, rsp):
         return body
 
 
+def wait_server_starting(server_port, client_port, tests, handler_cls=None):

Review comment:
       This is a factory method.  I would suggest a more "pythonic" approach would make this a class method of the TestServer class and call it everywhere we need to instantiate a TestServer. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org