You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/04 12:34:39 UTC
[GitHub] [airflow] EricGao888 opened a new pull request #21992: Switch oss hook tests in alibaba-provider to use Mocks (17617)
EricGao888 opened a new pull request #21992:
URL: https://github.com/apache/airflow/pull/21992
- At present, unit tests of oss hook in alibaba-provider uses real OSS(remote object storage service), which is not a good practice for unit test and could cause stability issues. Furthermore, most of test cases for OSSHook object are absent.
- This pr refactors the previous oss hook unit tests and uses unittest.mock to get rid of communications with real OSS.
- This pr also adds test cases to cover all functions for OSSHook object.
- related: #17617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] EricGao888 commented on pull request #21992: Switch oss hook tests in alibaba-provider to use Mocks (17617)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on pull request #21992:
URL: https://github.com/apache/airflow/pull/21992#issuecomment-1059132125
> * At present, unit tests of oss hook in alibaba-provider uses real OSS(remote object storage service), which is not a good practice for unit test and could cause stability issues. Furthermore, most of test cases for OSSHook object are absent.
> * This pr refactors the previous oss hook unit tests and uses unittest.mock to get rid of communications with real OSS.
> * This pr also adds test cases to cover all functions for OSSHook object.
> * related: [Switch Alibaba tests to use Mocks #17617](https://github.com/apache/airflow/issues/17617)
This commit fixed unit tests in oss hook. If it works, I will fix those in oss_task_handler, oss operator and oss sensor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21992: Switch oss hook tests in alibaba-provider to use Mocks (17617)
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21992:
URL: https://github.com/apache/airflow/pull/21992#issuecomment-1060092968
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21992: Switch oss hook tests in alibaba-provider to use Mocks (17617)
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21992:
URL: https://github.com/apache/airflow/pull/21992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org