You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/19 06:02:54 UTC

[GitHub] [cordova-ios] dpogue opened a new pull request #910: Set $PROJECT_NAME properly when installing plugins

dpogue opened a new pull request #910:
URL: https://github.com/apache/cordova-ios/pull/910


   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   When installing plugins, the `$PACKAGE_NAME` value was pulled from the Info.plist, which is the string `$(PRODUCT_BUNDLE_IDENTIFIER)` instead of the actual value of the PRODUCT_BUNDLE_IDENTIFIER as defined in the Xcode project file.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Change `getPackageName()` to always try to replace `$(...)` variables with their values from the Xcode Project.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Added spec tests, and manual testing.
   
   
   ### Checklist
   
   - [ x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] dpogue merged pull request #910: Set $PROJECT_NAME properly when installing plugins

Posted by GitBox <gi...@apache.org>.
dpogue merged pull request #910:
URL: https://github.com/apache/cordova-ios/pull/910


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org