[jira] [Commented] (MRUNIT-189) MapDriverBase.withInput comments state same as setInput but uses addInput

["Brock Noland (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MRUNIT-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796854#comment-13796854 ] 

Brock Noland commented on MRUNIT-189:
-------------------------------------

[~TerryKoch] looks good! One thing I would change:

"returns the MapDriverBase instance"

We use generics and a little trickier to get the return type to the implementor. So we actually return MapDriver not MapDriverBase:
https://github.com/apache/mrunit/blob/trunk/src/main/java/org/apache/hadoop/mrunit/MapDriverBase.java#L168



> MapDriverBase.withInput comments state same as setInput but uses addInput
> -------------------------------------------------------------------------
>
>                 Key: MRUNIT-189
>                 URL: https://issues.apache.org/jira/browse/MRUNIT-189
>             Project: MRUnit
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>         Environment: OS X mac book pro
>            Reporter: John Conwell
>            Priority: Minor
>              Labels: documentation
>         Attachments: MRUNIT-189_v1.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Comments for MapDriverBase.withInput state its the same as setInput() but uses addInput() instead.  Not a horrible issue but setInput clears the inputs List.  So the expected behavior (via the documentation) is that if I call withInput 4 times, I'll only have 1 value in the inputs List.



--
This message was sent by Atlassian JIRA
(v6.1#6144)